[OCPCLOUD-1162] Implement image substitution for Pod and generalise the approach for other objects

[Danil-Grigorev]

This will add support for image substitution in static pod, used in render implementation.

[JoelSpeed]

LGTM, got a couple of nits, LMK if you disagree

[Danil-Grigorev]

@JoelSpeed The PR is ready, but we can't merge it just yet, or we risk destroying our CI once openshift/installer#4947 is merged, just after operator is added to release. We need to add all supported provider forks into release first, then merge this PR. Currently it is Azure and AWS.

/hold

[JoelSpeed]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JoelSpeed]

@JoelSpeed The PR is ready, but we can't merge it just yet, or we risk destroying our CI once openshift/installer#4947 is merged, just after operator is added to release. We need to add all supported provider forks into release first, then merge this PR. Currently it is Azure and AWS.

@Danil-Grigorev I don't see how this PR would affect that specifically? Does the operator not wait until there is a feature gate present before doing anything? I would have thought during bootstrap it would also only generate a pod if the FG is present or it knows that platform is specifically GA'd as out of tree? Did we change what we are doing here?

[openshift-ci]

@Danil-Grigorev: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-ccm	c60a1e9	link	/test e2e-aws-ccm

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Danil-Grigorev]

/hold cancel

It is safe to merge, as the operator could not be added to release before each provider is added.

[lobziik]

/lgtm