Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local image build #98

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

tnozicka
Copy link
Contributor

Fixes local image build failure with imagebuilder openshift/imagebuilder#140

/cc @sallyom

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 10, 2019
@tnozicka
Copy link
Contributor Author

/cc @soltysh

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @mfojtik
for approval

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2019
@soltysh
Copy link
Member

soltysh commented Oct 10, 2019

/retest

@sallyom
Copy link
Contributor

sallyom commented Oct 10, 2019

this is a bandaid, but it works - although have to work around this, also 🤷‍♀️

@soltysh
Copy link
Member

soltysh commented Oct 11, 2019

this is a bandaid, but it works - although have to work around this, also woman_shrugging

Yeah, I've noticed that, but you can just pull that image and re-try, which is better than not being able to build at all 😉

@sttts
Copy link
Contributor

sttts commented Oct 11, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 22bfa37 into openshift:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants