Bug 1992255: Fix leader election defaults in snapshot-controller #99
Conversation
Bump kube libraries, openshift/library-go, openshift/api, snapshotter client among others.
openshift-ci
bot
added
the
bugzilla/severity-high
|
@bertinatto: This pull request references Bugzilla bug 1992255, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test unit |
Current defaults cause pod restarts when apiserver is unavailable for longer than 60 seconds. The values set in this patch come from https://github.com/openshift/library-go/blob/master/pkg/config/leaderelection/leaderelection.go.
This is longer needed since we moved to the built-in embeded package
bertinatto
force-pushed
the
fix-leader-election-values-for-sno
branch
from
fcabc01 to
9e21b0b
Compare
|
/retest |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test all |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/test e2e-upgrade |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@bertinatto: All pull requests linked via external trackers have merged: Bugzilla bug 1992255 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Current leader election defaults cause pod restarts when apiserver is unavailable for longer than 60 seconds. The values set in this patch come from https://github.com/openshift/library-go/blob/master/pkg/config/leaderelection/leaderelection.go.
Also, this patchset bump some libraries for OCP 4.9 release: kube libraries, openshift/library-go, openshift/api, snapshotter client among others.
Besides that, I'm removing go-bindata dependency that's no longer used since we're now using the
embedbuilt-in package.CC @openshift/storage