Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow setting router image in hack/release-local.sh #1088

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rfredette
Copy link
Contributor

The default router image in the ingress operator deployment manifest is not up to date, and sometimes causes red herring issues when debugging changes.

With this change, a user can set the IMAGE environment variable to a router image pullspec, and hack/release-local.sh will update the deployment manifest to use the specified image.

Alternatively, a user can set the GET_IMAGE environment variable to a non-empty value, and hack/release-local.sh will query the cluster in the user's default kubeconfig to automatically get the router image currently in use and use the same image in its generated manifests. Note that GET_IMAGE requires read access to the openshift-ingress-operator/ingress-operator deployment.

The default router image in the ingress operator deployment manifest is
not up to date, and sometimes causes red herring issues when debugging
changes.

With this change, a user can set the IMAGE environment variable to a
router image pullspec, and hack/release-local.sh will update the
deployment manifest to use the specified image.

Alternatively, a user can set the GET_IMAGE environment variable to a
non-empty value, and hack/release-local.sh will query the cluster in the
user's default kubeconfig to automatically get the router image
currently in use and use the same image in its generated manifests.
Note that GET_IMAGE requires read access to the
openshift-ingress-operator/ingress-operator deployment.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2024
@openshift-ci openshift-ci bot requested review from alebedev87 and Miciah June 13, 2024 20:35
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rfredette. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@rfredette: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator ebf53e5 link true /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants