deps: integrate with latest openshift version #195
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
| @@ -1,10 +1,6 @@ | |||
| # Force dep to vendor the code generators, which aren't imported just used at dev time. | |||
| # Picking a subpackage with Go code won't be necessary once https://github.com/golang/dep/pull/1545 is merged. | |||
| required = [ | |||
| "k8s.io/code-generator/cmd/defaulter-gen", | |||
There was a problem hiding this comment.
Are these code generators being removed b/c golang/dep#1545 merged?
There was a problem hiding this comment.
Latest commit cleans up the entire file including the required stanza. We still need some stuff in required for non-imported code generation, but the subpackage note isn't relevant to us.
Gopkg.toml
Outdated
| @@ -38,24 +34,34 @@ required = [ | |||
|
|
|||
| [[constraint]] | |||
| name = "github.com/openshift/library-go" | |||
| revision = "fc4b2d5cbcf0ab855422e340c78fe7a53a38bee3" | |||
| revision = "9067dee609b10991fa6c26b5d51fe095b2331027" | |||
There was a problem hiding this comment.
Is there a reason for using this rev instead of latest (dab26bb3a8dc7fccde7227194af755bbff30ce5d)?
There was a problem hiding this comment.
Typo on my part, good catch!
ironcladlou
force-pushed
the
update-client
branch
2 times, most recently
from
3081209
to
b10985e
Compare
ironcladlou
force-pushed
the
update-client
branch
2 times, most recently
from
5cc98f4
to
8506f80
Compare
ironcladlou
changed the title
ironcladlou
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Need a resolution to kubernetes-sigs/controller-runtime#383. /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
@openshift/sig-network-edge I don't want to wait for this. I'd like to carry the patched If there are no objections, I'll do this tomorrow (April 5). |
ironcladlou
force-pushed
the
update-client
branch
from
8506f80
to
a128c7f
Compare
|
I figured, why wait. I went ahead and pushed the local Source implementation. If upstream patches it'll be trivial to delete our local version. This is ready for review. /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/test e2e-aws |
Upgrade to the latest libraries compatible with openshift/api and library-go.
ironcladlou
force-pushed
the
update-client
branch
from
a128c7f
to
522096b
Compare
|
kubernetes-sigs/controller-runtime#383 merged last night so I fixed up the PR to use it! |
|
/retest |
|
Typo in the commit message: "libary-go". |
ironcladlou
force-pushed
the
update-client
branch
from
522096b
to
cdb2196
Compare
Fixed |
pkg/util/source/doc.go
Outdated
| // | ||
| // If upstream accepts the patch, this package can be deleted and replaced by | ||
| // upstream code. | ||
| package source |
There was a problem hiding this comment.
Looks like your forgot to remove this file.
There was a problem hiding this comment.
I must have failed to isolate those changed in the deleted commit. Thanks!
* Upgrade to latest openshift/api and library-go * Upgrade to kube 1.13 * Upgrade to latest compatible controller-runtime Fixes openapi spec generation, which as of the previous version was not picking up field descriptions.
ironcladlou
force-pushed
the
update-client
branch
from
cdb2196
to
c569f18
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Fixes openapi spec generation, which as of the previous version was not picking
up field descriptions.