Update to operator-sdk 0.1.1 #82
Conversation
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
openshift-ci-robot
added
the
approved
|
/retest |
Refactor all the operator internals to use controller-runtime. This is necessary to unpin the operator from outdated kube dependencies. The refactor should be functionally transparent.
ironcladlou
force-pushed
the
operator-sdk-0.1.x-forreal
branch
from
975b519
to
94ef6e2
Compare
|
/unhold |
|
@openshift/sig-network-edge PTAL /cc @bparees @shawn-hurley |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| sdk "github.com/operator-framework/operator-sdk/pkg/sdk" | ||
| k8sutil "github.com/operator-framework/operator-sdk/pkg/util/k8sutil" | ||
| sdkVersion "github.com/operator-framework/operator-sdk/version" | ||
| "github.com/operator-framework/operator-sdk/pkg/k8sutil" |
There was a problem hiding this comment.
Looking at the changes, operator-sdk pkg is used only here, mainly to get WATCH_NAMESPACE env.
Why not use os.LookupEnv(...) directly and get rid of operator-sdk pkg dependency?
There was a problem hiding this comment.
Good point. I'd actually also consider switching to a Cobra command and consuming this from flags anyway. In either case, seems like a followup?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, pravisankar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refactor all the operator internals to use controller-runtime. This is necessary to unpin the operator from outdated kube dependencies.
The refactor should be functionally transparent.
Unfortunately, my best advice right now for reasoning through these changes is to dive into the controller-runtime docs and source.
The new
OperatorManageris (I think) the key abstraction which enables our class of operator (multi-namespaces) to make use of controller-runtime. There are ongoing discussions and prototypes upstream to try and support the use case — if and when those materialize, we can revisit our architecture.Replaces #70.