Commits on Nov 23, 2022

1. configurable-route: Don't use NewKindWithCache …

   Replace source.NewKindWithCache(&foo{}, mgr.GetCache()) with
   &source.Kind{Type: &foo{}} in the configurable-route controller.
   
   Using source.NewKindWithCache() is needlessly complicated since this
   controller uses the default cache anyway.  Moreover, using
   source.NewKindWithCache() causes controller-runtime's logging to be more
   noisy.  Before this commit, the operator emitted log messages like the
   following on startup:
   
       2022-11-23T08:47:35.646-0600    INFO    operator.init   controller/controller.go:241    Starting EventSource    {"controller": "configurable_route_controller", "source": "&{{%!s(*v1.Role=&{{ } {      0 {{0 0 <nil>}} <nil> <nil> map[] map[] [] [] []} []}) %!s(*cache.multiNamespaceCache=&{map[openshift-config:0xc000712110 openshift-config-managed:0xc000712108 openshift-ingress:0xc0007120f8 openshift-ingress-canary:0xc000712100 openshift-ingress-operator:0xc0007120e8] 0xc000261ea0 0xc00010e190 0xc0007120e0}) %!s(chan error=<nil>) %!s(func()=<nil>)}}"}
       2022-11-23T08:47:35.646-0600    INFO    operator.init   controller/controller.go:241    Starting EventSource    {"controller": "configurable_route_controller", "source": "&{{%!s(*v1.RoleBinding=&{{ } {      0 {{0 0 <nil>}} <nil> <nil> map[] map[] [] [] []} [] {  }}) %!s(*cache.multiNamespaceCache=&{map[openshift-config:0xc000712110 openshift-config-managed:0xc000712108 openshift-ingress:0xc0007120f8 openshift-ingress-canary:0xc000712100 openshift-ingress-operator:0xc0007120e8] 0xc000261ea0 0xc00010e190 0xc0007120e0}) %!s(chan error=<nil>) %!s(func()=<nil>)}}"}
       2022-11-23T08:47:35.646-0600    INFO    operator.init   controller/controller.go:241    Starting Controller     {"controller": "configurable_route_controller"}
   
   After this commit, the operator instead emits log messages like the
   following:
   
       2022-11-23T08:48:43.076-0600    INFO    operator.init   controller/controller.go:241    Starting EventSource    {"controller": "configurable_route_controller", "source": "kind source: *v1.Role"}
       2022-11-23T08:48:43.078-0600    INFO    operator.init   controller/controller.go:241    Starting EventSource    {"controller": "configurable_route_controller", "source": "kind source: *v1.RoleBinding"}
       2022-11-23T08:48:43.078-0600    INFO    operator.init   controller/controller.go:241    Starting Controller     {"controller": "configurable_route_controller"}
   
   Follow-up to commit baf2d3e.
   
   This commit fixes OCPBUGS-4054.
   
   https://issues.redhat.com/browse/OCPBUGS-4054
   
   * pkg/operator/controller/configurable-route/controller.go (New): Replace
   source.NewKindWithCache() with source.Kind{}.

   

   Miciah committed Nov 23, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 25eee8e
   • Browse repository at this point

   Copy the full SHA

   25eee8e View commit details

   Browse the repository at this point in the history