-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-4759: Do not manage DNS for an ingresscontroller with domain mismatch in GCP #866
OCPBUGS-4759: Do not manage DNS for an ingresscontroller with domain mismatch in GCP #866
Conversation
@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
/unhold |
/jira refresh |
@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @frobware |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…n that does not match the baseDomain of the cluster DNS config for GCP This had been previously done for AWS, now expanding to GCP. - pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain - pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP
c50865e
to
cb8d9bb
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/test e2e-aws-ovn-serial |
Looks like the AWS cluster did not get created sucessfully:
/test e2e-aws-ovn-serial |
@gcs278: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@gcs278: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-4759 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.
This had been previously done for AWS (#761), now expanding to GCP.