Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-4759: Do not manage DNS for an ingresscontroller with domain mismatch in GCP #866

Merged
merged 1 commit into from
Jan 13, 2023
Merged

OCPBUGS-4759: Do not manage DNS for an ingresscontroller with domain mismatch in GCP #866

merged 1 commit into from
Jan 13, 2023

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Dec 12, 2022 •
edited

Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.

This had been previously done for AWS (#761), now expanding to GCP.

  • pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain
  • pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2022
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is invalid:

  • expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.

This had been previously done for AWS, now expanding to GCP.

  • pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain
  • pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278
Copy link
Contributor Author

gcs278 commented Dec 12, 2022

/hold
Waiting for confirmation GCP indeed can't create domains outside of it's cluster domain or does something weird like appending domains (like azure).

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2022
@gcs278
Copy link
Contributor Author

gcs278 commented Dec 13, 2022

/unhold
I confirmed GCP doesn't do wacky things with mismatching DNS domains, like treating it as a subdomain.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@gcs278
Copy link
Contributor Author

gcs278 commented Dec 13, 2022

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is invalid:

  • expected the bug to target the "4.13.0" version, but it targets "4.13" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278
Copy link
Contributor Author

gcs278 commented Dec 13, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 13, 2022
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@candita
Copy link
Contributor

candita commented Dec 14, 2022

/assign @frobware

@gcs278
Copy link
Contributor Author

gcs278 commented Dec 21, 2022

/retest-required

2 similar comments
@gcs278
Copy link
Contributor Author

gcs278 commented Dec 22, 2022

/retest-required

@gcs278
Copy link
Contributor Author

gcs278 commented Jan 3, 2023

/retest-required

@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-4759, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.

This had been previously done for AWS (#761), now expanding to GCP.

  • pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain
  • pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lihongan January 11, 2023 17:29
@gcs278
OCPBUGS-4759: Do not manage DNS for an ingresscontroller with a domai…
cb8d9bb 
…n that does not match

the baseDomain of the cluster DNS config for GCP

This had been previously done for AWS, now expanding to GCP.

- pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain
- pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP
@frobware
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@Miciah
Copy link
Contributor

Miciah commented Jan 11, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 560b2d3 and 2 for PR HEAD cb8d9bb in total

@gcs278
Copy link
Contributor Author

gcs278 commented Jan 12, 2023

/retest-required

@candita
Copy link
Contributor

candita commented Jan 13, 2023

/test e2e-aws-ovn-serial
/test e2e-gcp-ovn

@frobware
Copy link
Contributor

Looks like the AWS cluster did not get created sucessfully:


openshift cluster install failed with other errors
 
level=fatal msg=failed to fetch Terraform Variables: failed to fetch dependency of "Terraform Variables": failed to generate asset "Platform Provisioning Check": baseDomain: Invalid value: "origin-ci-int-aws.dev.rhcloud.com": the zone already has record sets for the domain of the cluster: [api.ci-op-di99mig1-52591.origin-ci-int-aws.dev.rhcloud.com

/test e2e-aws-ovn-serial

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8d2294d and 1 for PR HEAD cb8d9bb in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 13, 2023

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-serial cb8d9bb link true /test e2e-gcp-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dc49def and 0 for PR HEAD cb8d9bb in total

@openshift-merge-robot openshift-merge-robot merged commit fc69408 into openshift:master Jan 13, 2023
@openshift-ci-robot
Copy link
Contributor

@gcs278: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4759 has been moved to the MODIFIED state.

In response to this:

Do not manage DNS for an ingresscontroller with a domain that does not match the baseDomain of the cluster DNS config for GCP.

This had been previously done for AWS (#761), now expanding to GCP.

  • pkg/operator/controller/ingress/dns.go: Add GCP domain validation to manageDNSForDomain
  • pkg/operator/controller/ingress/dns_test.go: Add unit tests for manageDNSForDomain with GCP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@rfredette rfredette Awaiting requested review from rfredette

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@frobware frobware

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gcs278 @openshift-ci-robot @candita @frobware @Miciah @openshift-merge-robot