Simplify multi-namespace controller setup #87
Conversation
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
approved
pkg/operator/operator.go
Outdated
| go func() { | ||
| if err := cache.Start(stop); err != nil { | ||
| // TODO: propagate to stop channel? | ||
| logrus.Infof("cache stopped with error: %v", err) |
There was a problem hiding this comment.
You need to crash and die when this happens - this would be a limping operator that stops reacting to events
There was a problem hiding this comment.
Good point. Refactored to handle async cache failures. Wonder if we should crash if a cache returns at all regardless of error (since we don't restart the caches)...
Simplify the multi-namespace controller setup by leveraging the source.Informer and cache.Cache structures. This allows the deletion of the OperatorManager structure and concept.
ironcladlou
force-pushed
the
manager-refactor
branch
from
00070c6
to
636faa5
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
@pravisankar @ramr can you re-tag? Looks like the bots missed it |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Simplify the multi-namespace controller setup by leveraging the source.Informer
and cache.Cache structures. This allows the deletion of the OperatorManager
structure and concept.