-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-6701: Avoid spurious updates for scope in IngressClass #879
OCPBUGS-6701: Avoid spurious updates for scope in IngressClass #879
Conversation
@gcs278: This pull request references Jira Issue OCPBUGS-6701, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @Miciah |
d94ff8a
to
c5a4062
Compare
Specify spec.parameters.scope on ingressclasses that the operator creates. Before this commit, the update logic would try to revert the default value that the API set for an ingressclass's scope field. * pkg/operator/controller/ingressclass/ingressclass.go (desiredIngressClass): Specify spec.parameters.scope with the default value: "Cluster". * pkg/operator/controller/ingressclass/ingressclass_test.go (Test_desiredIngressClass): Update test to expect spec.parameters.scope to be set.
c5a4062
to
739e3ed
Compare
/retest |
Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@gcs278: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
@gcs278: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-6701 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.13 |
@candita: new pull request could not be created: failed to create pull request against openshift/cluster-ingress-operator#release-4.13 from head openshift-cherrypick-robot:cherry-pick-879-to-release-4.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between openshift:release-4.13 and openshift-cherrypick-robot:cherry-pick-879-to-release-4.13"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cancel cherry-pick |
/cherry-pick release-4.12 |
@candita: new pull request created: #1056 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Specify spec.parameters.scope on ingressclasses that the operator creates.
Before this commit, the update logic would try to revert the default value that the API set for an ingressclass's scope field.