Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NE-1186: Test_getRR: Fix typo: "excepted" → "expected" #883

Merged
merged 1 commit into from
Mar 1, 2023
Merged

NE-1186: Test_getRR: Fix typo: "excepted" → "expected" #883

merged 1 commit into from
Mar 1, 2023

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Jan 27, 2023

Test_getRR: Fix typo: "excepted" → "expected"

  • pkg/dns/alibaba/dns_test.go (Test_getRR): Replace "excepted" with "expected" in test case struct definition.

@Miciah @gcs278
NE-1186: Test_getRR: Fix typo: "excepted" → "expected"
f7bfa89 
* pkg/dns/alibaba/dns_test.go (Test_getRR): Replace "excepted" with
"expected" in test case struct definition.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 27, 2023 •
edited by openshift-ci bot
Loading

@gcs278: This pull request references NE-1186 which is a valid jira issue.

In response to this:

Test_getRR: Fix typo: "excepted" → "expected"

  • pkg/dns/alibaba/dns_test.go (Test_getRR): Replace "excepted" with "expected" in test case struct definition.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 27, 2023
@gcs278
Copy link
Contributor Author

gcs278 commented Jan 30, 2023

/retest-required

@gcs278
Copy link
Contributor Author

gcs278 commented Jan 31, 2023

/retest

@Miciah
Copy link
Contributor

Miciah commented Feb 22, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@gcs278
Copy link
Contributor Author

gcs278 commented Feb 22, 2023

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Feb 27, 2023

This is just a typo fix in a unit test; no docs, PX, or QE required.
/label docs-approved
/label px-approved
/label qe-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Feb 27, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8eb2c66 and 2 for PR HEAD f7bfa89 in total

@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/retest-required

5 similar comments
@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023 •
edited
Loading

@gcs278: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node f7bfa89 link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Miciah
Copy link
Contributor

Miciah commented Feb 28, 2023

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit ed65d6b into openshift:master Mar 1, 2023
@Miciah Miciah mentioned this pull request Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc Awaiting requested review from knobunc

@rfredette rfredette Awaiting requested review from rfredette

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gcs278 @openshift-ci-robot @Miciah @openshift-merge-robot