Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-6784: bump controller-runtime to fix the multi namespace cache indexing #913

Merged
merged 1 commit into from
May 3, 2023
Merged

OCPBUGS-6784: bump controller-runtime to fix the multi namespace cache indexing #913

merged 1 commit into from
May 3, 2023
+155 −103

Conversation

alebedev87
Copy link
Contributor

@alebedev87 alebedev87 commented Apr 25, 2023 •
edited
Loading

This PR aims at helping with the error produced by the certificate publisher controller: "Index with name field:defaultCertificateName does not exist".
The full investigation on why this controller runtime bump can help with the problem is in this bug comment.

Initial bug fix: kubernetes-sigs/controller-runtime#2252
Backport to 0.14: kubernetes-sigs/controller-runtime#2287

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 25, 2023
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-6784, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The full investigation on why this controller runtime bump can help with "Index with name field:defaultCertificateName does not exist" problem can be found in this bug comment.

Initial bug fix: kubernetes-sigs/controller-runtime#2252
Backport to 0.14: kubernetes-sigs/controller-runtime#2287

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 25, 2023
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-6784, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR aims at helping with the error produced by the certificate publisher controller: "Index with name field:defaultCertificateName does not exist".
The full investigation on why this controller runtime bump can help with the problem is in this bug comment.

Initial bug fix: kubernetes-sigs/controller-runtime#2252
Backport to 0.14: kubernetes-sigs/controller-runtime#2287

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 25, 2023
@alebedev87
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-6784, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lihongan April 25, 2023 19:31
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-6784, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alebedev87
Copy link
Contributor Author

/retest

1 similar comment
@alebedev87
Copy link
Contributor Author

/retest

@alebedev87 alebedev87 mentioned this pull request May 2, 2023
Merged
@alebedev87
Copy link
Contributor Author

/retest

2 similar comments
@alebedev87
Copy link
Contributor Author

/retest

@alebedev87
Copy link
Contributor Author

/retest

@alebedev87
Copy link
Contributor Author

/assign @Miciah

As you know the context.

@Miciah
Copy link
Contributor

Miciah commented May 3, 2023

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@alebedev87 alebedev87 mentioned this pull request May 3, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD daad954 and 2 for PR HEAD ec1c776 in total

@alebedev87
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 093e973 into openshift:master May 3, 2023
@openshift-ci-robot
Copy link
Contributor

@alebedev87: Jira Issue OCPBUGS-6784: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6784 has been moved to the MODIFIED state.

In response to this:

This PR aims at helping with the error produced by the certificate publisher controller: "Index with name field:defaultCertificateName does not exist".
The full investigation on why this controller runtime bump can help with the problem is in this bug comment.

Initial bug fix: kubernetes-sigs/controller-runtime#2252
Backport to 0.14: kubernetes-sigs/controller-runtime#2287

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-ingress-operator-container-v4.14.0-202305040041.p0.g093e973.assembly.stream for distgit ose-cluster-ingress-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmzuccarelli lmzuccarelli Awaiting requested review from lmzuccarelli

@rfredette rfredette Awaiting requested review from rfredette

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alebedev87 @openshift-ci-robot @Miciah @openshift-bot @openshift-merge-robot