Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-13071: Fix TestClientTLS flakes #923

Merged
merged 3 commits into from
May 5, 2023
Merged

[release-4.13] OCPBUGS-13071: Fix TestClientTLS flakes #923

merged 3 commits into from
May 5, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #904

/assign Miciah

rfredette and others added 3 commits May 3, 2023 19:55
@rfredette
Fix TestClientTLS: Wait for old router pods to be cleaned up before t…
7bc9214 
…esting new mTLS config
@rfredette
Rename waitForDeploymentCompleteWithCleanup to waitForDeploymentCompl…
2e514cb 
…eteWithOldPodTermination

Also:
- Rename pods to podList
- When checking for old pod termination, only count the currently ready
  pods, instead of all pods
@Miciah
waitForDeploymentCompleteWithOldPodTermination fix
e0078fd 
Follow-up to commit 20e4e38.

* test/e2e/operator_test.go
(waitForDeploymentCompleteWithOldPodTermination): Correct the function name
in the godoc.  Use "k8s.io/utils/pointer".Int32Deref, and respect the value
in spec.replicas even if it is set explicitly to 0.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 3, 2023
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-10846 has been cloned as Jira Issue OCPBUGS-13071. Will retitle bug to link to clone.
/retitle [release-4.13] OCPBUGS-13071: Fix TestClientTLS flakes

In response to this:

This is an automated cherry-pick of #904

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-10846: Fix TestClientTLS flakes [release-4.13] OCPBUGS-13071: Fix TestClientTLS flakes May 3, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 3, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-13071, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.0) matches configured target version for branch (4.13.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-10846 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-10846 targets the "4.14.0" version, which is one of the valid target versions: 4.14.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #904

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah Miciah mentioned this pull request May 3, 2023
Merged
@openshift-ci openshift-ci bot requested a review from lihongan May 3, 2023 19:56
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

[release-4.13] OCPBUGS-13071: Fix TestClientTLS flakes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from frobware and gcs278 May 3, 2023 19:58
@Miciah
Copy link
Contributor

Miciah commented May 3, 2023

This is a clean cherry-pick to fix a flaky test with no changes outside of the problematic E2E test itself.
/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 3, 2023
@ShudiLi
Copy link
Member

ShudiLi commented May 4, 2023

/label cherry-pick-approved
thanks

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 4, 2023
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6aa482c and 2 for PR HEAD e0078fd in total

@Miciah
Copy link
Contributor

Miciah commented May 4, 2023

e2e-aws-operator failed on TestRouterCompressionOperation. Looks like we'll need to backport the fix for that test failure too (#920).
/test e2e-aws-operator

@gcs278
Copy link
Contributor

gcs278 commented May 5, 2023

Backport created for TestRouterCompressionOperation fix: #926

@Miciah
Copy link
Contributor

Miciah commented May 5, 2023

e2e-aws-operator failed on TestUnmanagedDNSToManagedDNSInternalIngressController. I updated OCPBUGS-10983, which is tracking that test failure, to note that it affects 4.13 as well as 4.14.
/override ci/prow/e2e-aws-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-aws-operator

In response to this:

e2e-aws-operator failed on TestUnmanagedDNSToManagedDNSInternalIngressController. I updated OCPBUGS-10983, which is tracking that test failure, to note that it affects 4.13 as well as 4.14.
/override ci/prow/e2e-aws-operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2023

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator e0078fd link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knobunc knobunc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label May 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 43b7ef2 into openshift:release-4.13 May 5, 2023
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-13071: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13071 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #904

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihongan lihongan Awaiting requested review from lihongan

@frobware frobware Awaiting requested review from frobware

@gcs278 gcs278 Awaiting requested review from gcs278

Assignees

@Miciah Miciah

@lihongan lihongan

@melvinjoseph86 melvinjoseph86

@ShudiLi ShudiLi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@openshift-cherrypick-robot @openshift-ci-robot @Miciah @ShudiLi @gcs278 @knobunc @lihongan @openshift-merge-robot @melvinjoseph86 @rfredette