OCPBUGS-34544: Disable PersistentVolumeLabel admission plugin #1693
Conversation
PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in OCP 4.17, and thus it reject valid in-tree GCE PersistentVolumes. The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway.
openshift-ci-robot
added
jira/severity-moderate
|
@jsafrane: This pull request references Jira Issue OCPBUGS-34544, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in HyperShift, and thus it rejects valid Azure Disk PVs. The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway. It's also being disabled in standalone OCP, openshift/cluster-kube-apiserver-operator#1693
|
/retest |
|
k8s-e2e-gcp-serial with failing SELinuxMount metrics is not related to this PR - it most probably needs kubelet 1.30, which is not yet present in RHCOS. |
|
thanks for posting this @jsafrane /lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, jsafrane, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit 94ca049
into
openshift:master
|
@jsafrane: Jira Issue OCPBUGS-34544: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-34544 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.17.0-202406060211.p0.g94ca049.assembly.stream.el9 for distgit ose-cluster-kube-apiserver-operator. |
PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in HyperShift, and thus it rejects valid Azure Disk PVs. The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway. It's also being disabled in standalone OCP, openshift/cluster-kube-apiserver-operator#1693
|
/cherry-pick release-4.16 |
|
@rphillips: new pull request created: #1702 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in HyperShift, and thus it rejects valid Azure Disk PVs. The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway. It's also being disabled in standalone OCP, openshift/cluster-kube-apiserver-operator#1693
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
Remove PersistentVolumeLabel admission plugin from the default list of enabled admissions. The plugin is deprecated upstream and most of its functionality was removed in 1.29 and 1.30. This is continuation of openshift/cluster-kube-apiserver-operator#1693, the admission is enabled on multiple places.
PersistentVolumeLabel admission plugin needs a valid cloud config. kube-apiserver does not get it in OCP 4.17, and thus it rejects valid in-tree GCE PersistentVolumes.
The admission plugin was deprecated upstream a long time ago, it was removed from Kubernetes 1.31 (OCP 4.18) and it cannot work without a cloud provider in kube-apiserver anyway.
cc @openshift/storage