Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps #84

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Fix deps #84

merged 1 commit into from
Mar 27, 2019

Conversation

soltysh
Copy link

@soltysh soltysh commented Mar 27, 2019

It looks like #67 broke deps, which are constantly failing in #80. This does a fresh bump.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 27, 2019
@sttts
Copy link
Contributor

sttts commented Mar 27, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 27, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@soltysh
Copy link
Author

soltysh commented Mar 27, 2019

git add -f . solved the problem for me, it was missing hidden files /cc @damemi

@sttts
Copy link
Contributor

sttts commented Mar 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Author

soltysh commented Mar 27, 2019

/retest

@ravisantoshgudimetla
Copy link
Contributor

ohh @soltysh, thanks for picking this up, I had a PR #83 up yesterday but couldn't complete it before the end of my day but thanks, wondering why you have 194 files while I have 60 files in my bump and yes I did git add -f too.

@ravisantoshgudimetla ravisantoshgudimetla mentioned this pull request Mar 27, 2019
@soltysh
Copy link
Author

soltysh commented Mar 27, 2019

@ravisantoshgudimetla I'm guessing it's the time between when you did the bump and I did, stuff merged in between so it required more changes

@ravisantoshgudimetla
Copy link
Contributor

@ravisantoshgudimetla
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

@soltysh: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 8f3311c link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sjenning sjenning merged commit 1e53399 into openshift:master Mar 27, 2019
@soltysh soltysh deleted the fix_deps branch March 28, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants