Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Operator restructure" #9

Merged
merged 1 commit into from
Dec 22, 2018
Merged

Revert "Operator restructure" #9

merged 1 commit into from
Dec 22, 2018

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Dec 22, 2018 •
edited
Loading

Reverts #8

Post merge seeing a large number of e2e-aws failures across all repos on machine-approver-controller restarting.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 22, 2018
@smarterclayton
Copy link
Contributor Author

@wking if this greens I'm going to revert

@smarterclayton smarterclayton mentioned this pull request Dec 22, 2018
Merged
@wking
Copy link
Member

wking commented Dec 22, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2018
@abhinavdahiya
Copy link

@smarterclayton this is green

@enj
Copy link
Contributor

enj commented Dec 22, 2018

lol, great. Get to do this again. Failure logs would be awesome so we can figure out what broke. Maybe another manifest issue.

@wking
Copy link
Member

wking commented Dec 22, 2018

I dropped some log excerpts here.

@enj
Copy link
Contributor

enj commented Dec 22, 2018

Hmm restart technically occurrs because it lost leader election. We could turn that off I guess. The 127.0.0.1 ip also looks weird.

@smarterclayton smarterclayton added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor Author

Logs are in all the linked jobs

@openshift-merge-robot openshift-merge-robot merged commit 2465eb1 into master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrogers950 mrogers950 Awaiting requested review from mrogers950

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@smarterclayton @wking @abhinavdahiya @enj @openshift-ci-robot @openshift-merge-robot