Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upstream UI URLs #1223

Closed
wants to merge 2 commits into from
Closed

Remove upstream UI URLs #1223

wants to merge 2 commits into from

Conversation

philipgough
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

This is related to console/#9276 and see epic 1591 for context

@openshift-ci openshift-ci bot requested review from bison and raptorsun June 16, 2021 14:47
@philipgough philipgough changed the title Mon 1658 Remove upstream UI URLs Jun 16, 2021
@simonpasquier
Copy link
Contributor

/lgtm
/hold
this needs openshift/console#9276 (at least) to be merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 16, 2021
@philipgough
Copy link
Contributor Author

/retest

1 similar comment
@philipgough
Copy link
Contributor Author

/retest

@paulfantom paulfantom mentioned this pull request Jun 30, 2021
Merged
2 tasks
@philipgough philipgough mentioned this pull request Jul 1, 2021
Merged
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 7, 2021
@philipgough
Remove reference to upstream UI's and shared config
213ba30 
This change implements the first stage of deprecating upstream UI
components that we no lonbger wish to support.

See https://issues.redhat.com/browse/MON-1658 anmd related changes in
openshift/console-operator#562 and
openshift/console#9276
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PhilipGough, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [PhilipGough,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier simonpasquier mentioned this pull request Jul 22, 2021
Merged
2 tasks
@simonpasquier
Copy link
Contributor

Ah I realized that we should probably keep the ConfigSharingTask task that would simply remove the openshift-config-managed/monitoring-shared-config configmap in 4.9 and then we can kill the task in 4.10.

@simonpasquier
Copy link
Contributor

/hold

@philipgough
Copy link
Contributor Author

@simonpasquier I've addressed you comment (I think) in a second commit just so it is easier to review the change but lets squash them prior to merge.

That change also led me to question how/if we will handle the cleanup of routes or are we going to continue to create those?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

@philipgough: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic 52fb9d3 link /test e2e-agnostic
ci/prow/go-fmt 52fb9d3 link /test go-fmt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

@philipgough: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2021
@philipgough
Copy link
Contributor Author

Closing as obsolete - "the current plan is to keep the routes (because of the multi-cluster console effort which is going to be dev preview in 4.10)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bison bison Awaiting requested review from bison

@raptorsun raptorsun Awaiting requested review from raptorsun

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipgough @simonpasquier