-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-1044: Add nodepools telemetry metrics for HyperShift #2265
HOSTEDCP-1044: Add nodepools telemetry metrics for HyperShift #2265
Conversation
@muraee: This pull request references HOSTEDCP-1044 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target only the "4.16.0" version, but multiple target versions were set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
015dee7
to
b309e79
Compare
b309e79
to
6a067a2
Compare
6a067a2
to
9c34b38
Compare
9c34b38
to
21ccb54
Compare
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From openshift/hypershift#3593 (comment)
changed to aggregate per HostedCluster, the maximum cardinality would between 80-100
So at most a single management cluster running the hypershift operator could generate 2 x 100 = 200 series. It's still way above the "automatically approved" limit (https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#request-approval).
Documentation/data-collection.md
Outdated
@@ -921,6 +921,16 @@ data: | |||
# platform:hypershift_nodepools:max is the total number of nodepools managed by the hypershift operator by cluster platform | |||
- '{__name__="platform:hypershift_nodepools:max"}' | |||
# | |||
# owners: (@openshift/team-hypershift-maintainers) | |||
# | |||
# cluster_name:hypershift_nodepools_size:sum is the total number of desired nodepool replicas managed by the hypershift operator per HostedCluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIUC HostedCluster = (cluster_name, exported_namespace) labels. Could these values contain identifying information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so
Another question: is there a need to correlate these metrics with the telemetry metrics emitted from the guest cluster? |
per HostedCluster, multiple HostedClusters can be created in the same management cluster.
No need cc @zanetworker |
I don't get it. Say that a management cluster runs 100 HostedClusters then the cardinality of |
cc @zanetworker, see #2265 (comment) (the previous mention failed). |
@simonpasquier exactly right. sorry I was thinking of something else. |
No need @simonpasquier |
7510925
to
1446005
Compare
/retest-required |
1446005
to
cbbf99c
Compare
- cluster_name:hypershift_nodepools_size:sum - cluster_name:hypershift_nodepools_available_replicas:sum
cbbf99c
to
3da125d
Compare
@simonpasquier are we ok to move forward and merge this? |
Not sure if this was discussed elsewhere already, but for a telemetry addition of this size we require management buy in. Please get @eparis approval for this. |
@eparis any comments/objections on this. This is needed to be able track cluster sizes in HyperShift. |
@eparis Ping :) |
Daniel reached out to me directly. I miss 99.9999%of github notifications :-( I approve. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, muraee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@muraee: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: cluster-monitoring-operator |
requires: openshift/hypershift#3593