HOSTEDCP-1044: Add nodepools telemetry metrics for HyperShift

[muraee]

• hypershift:nodepools:size
• hypershift:nodepools:available_replicas

requires: openshift/hypershift#3593

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[openshift-ci-robot]

@muraee: This pull request references HOSTEDCP-1044 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target only the "4.16.0" version, but multiple target versions were set.

In response to this:

• hypershift:nodepools:size
• hypershift:nodepools:available_replicas

requires: openshift/hypershift#3593

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[muraee]

/retest-required

[muraee]

cc @simonpasquier

[simonpasquier]

From openshift/hypershift#3593 (comment)

changed to aggregate per HostedCluster, the maximum cardinality would between 80-100

So at most a single management cluster running the hypershift operator could generate 2 x 100 = 200 series. It's still way above the "automatically approved" limit (https://rhobs-handbook.netlify.app/products/openshiftmonitoring/telemetry.md/#request-approval).

cc @jan--f @moadz

[simonpasquier]

IIUC HostedCluster = (cluster_name, exported_namespace) labels. Could these values contain identifying information?

[muraee]

I don't think so

[simonpasquier]

Another question: is there a need to correlate these metrics with the telemetry metrics emitted from the guest cluster?

[muraee]

So at most a single management cluster running the hypershift operator could generate 2 x 100 = 200 series

per HostedCluster, multiple HostedClusters can be created in the same management cluster.

Another question: is there a need to correlate these metrics with the telemetry metrics emitted from the guest cluster?

No need cc @zanetworker

[simonpasquier]

So at most a single management cluster running the hypershift operator could generate 2 x 100 = 200 series

per HostedCluster, multiple HostedClusters can be created in the same management cluster.

I don't get it. Say that a management cluster runs 100 HostedClusters then the cardinality of cluster_name:hypershift_nodepools_size:sum will be 100 (and the same for luster_name:hypershift_nodepools_available_replicas:sum hence the 200 series).Do you confirm?

[simonpasquier]

cc @zanetworker, see #2265 (comment) (the previous mention failed).

[muraee]

hence the 200 series).Do you confirm?

@simonpasquier exactly right. sorry I was thinking of something else.

[zanetworker]

Another question: is there a need to correlate these metrics with the telemetry metrics emitted from the guest cluster?

No need @simonpasquier

[muraee]

/retest-required

[muraee]

@simonpasquier are we ok to move forward and merge this?

[jan--f]

Not sure if this was discussed elsewhere already, but for a telemetry addition of this size we require management buy in. Please get @eparis approval for this.

[zanetworker]

@eparis any comments/objections on this. This is needed to be able track cluster sizes in HyperShift.

[zanetworker]

@eparis Ping :)

[eparis]

Daniel reached out to me directly. I miss 99.9999%of github notifications :-( I approve.

[jan--f]

/lgtm

[jan--f]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jan--f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c9a1d8d and 2 for PR HEAD 3da125d in total

[openshift-ci]

@muraee: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator
This PR has been included in build cluster-monitoring-operator-container-v4.18.0-202408131314.p0.g6525b00.assembly.stream.el9.
All builds following this will include this PR.