MON-3846: create separate kubelet-serving-ca cm for metrics-server #2333
Conversation
Signed-off-by: Jayapriya Pai <janantha@redhat.com>
|
@slashpai: This pull request references MON-3846 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@slashpai: This pull request references MON-3846 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@machine424 what do you think about proceeding with this or do we want to wait? |
| @@ -106,17 +106,19 @@ func (t *MetricsServerTask) create(ctx context.Context) error { | |||
| return fmt.Errorf("reconciling MetricsServer Service failed: %w", err) | |||
| } | |||
|
|
|||
| cacm, err := t.factory.PrometheusK8sKubeletServingCABundle(map[string]string{}) | |||
| kscm, err := t.client.GetConfigmap(ctx, "openshift-config-managed", "kubelet-serving-ca") | |||
There was a problem hiding this comment.
Because the bundle isn't nominative (like the client certificate), the optimal setup would be to have a unique configmap created by a task from the first stage (like NewMetricsClientCATask or something similar).
However, for now, let's just add some comments here + around
|
@slashpai: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is to avoid similar situation like https://issues.redhat.com/browse/OCPBUGS-32510 so that metrics-server
doesn't need to wait for prometheus task to create the configmap
cc: @machine424 @simonpasquier @jan--f