-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove job:kube_pv:count #2341
base: master
Are you sure you want to change the base?
Remove job:kube_pv:count #2341
Conversation
This commit removes job:kube_pv:count from telemetry as it's been deprecated and no longer contains any value Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weirdwiz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @weirdwiz. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for this. Of course, if you DO want this metric to disappear, that's another discussion. |
+1 to what Ayoub said. Dropping the metric from this list means that it will be rejected on the telemeter server side. It might be better to document the metric as being deprecated and remove it once it's not available in any supported OCP version. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This commit removes job:kube_pv:count from telemetry as it's been deprecated and no longer contains any value