Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-2065: jsonnet: exclude kubernetes-storage rules #2377

Merged
merged 1 commit into from
Jul 22, 2024
Merged

MON-2065: jsonnet: exclude kubernetes-storage rules #2377

merged 1 commit into from
Jul 22, 2024

Conversation

jan--f
Copy link
Contributor

@jan--f jan--f commented May 31, 2024

These alert rules are now hosted in the cluster-storage-operator. See openshift/cluster-storage-operator#477.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@jan--f
jsonnet: exclude kubernetes-storage rules
55325c5 
These alert rules are now hosted in the cluster-storage-operator. See
openshift/cluster-storage-operator#477.

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 31, 2024 •
edited by openshift-ci bot

@jan--f: This pull request references MON-2065 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

These alert rules are now hosted in the cluster-storage-operator. See openshift/cluster-storage-operator#477.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from marioferh and rexagod May 31, 2024 12:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@jan--f
Copy link
Contributor Author

jan--f commented Jun 17, 2024

/retest
/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 17, 2024 •
edited by openshift-ci bot

@jan--f: This pull request references MON-2065 which is a valid jira issue.

In response to this:

/retest
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33 duanwei33 mentioned this pull request Jul 10, 2024
Merged
@duanwei33
Copy link

Storage QE tested openshift/cluster-storage-operator#477, see
openshift/cluster-storage-operator#477 (comment).
Just FYI

marioferh
marioferh reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@marioferh marioferh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, marioferh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5341b80 and 2 for PR HEAD 55325c5 in total

@jan--f
Copy link
Contributor Author

jan--f commented Jul 10, 2024

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c40256c and 1 for PR HEAD 55325c5 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD c40256c and 2 for PR HEAD 55325c5 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

@jan--f: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 82b6cc1 into openshift:master Jul 22, 2024
18 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator
This PR has been included in build cluster-monitoring-operator-container-v4.17.0-202407230118.p0.g82b6cc1.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioferh marioferh marioferh left review comments

@rexagod rexagod Awaiting requested review from rexagod

Assignees

@marioferh marioferh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jan--f @openshift-ci-robot @duanwei33 @openshift-bot @marioferh