Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MON-3921: Revert "Revert "Merge pull request #2392 from machine424/f-… #2403

Merged
merged 1 commit into from
Aug 1, 2024
Merged

MON-3921: Revert "Revert "Merge pull request #2392 from machine424/f-… #2403

merged 1 commit into from
Aug 1, 2024

Conversation

machine424
Copy link
Contributor

…alert""

This reverts commit e1fc00b.

To re-introduce changes in #2392

This will be merged once the new e2e-hypershift-conformance test is green.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 3, 2024 •
edited by openshift-ci bot

@machine424: This pull request references MON-3921 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

…alert""

This reverts commit e1fc00b.

To re-introduce changes in #2392

This will be merged once the new e2e-hypershift-conformance test is green.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@machine424
Copy link
Contributor Author

/retest

1 similar comment
@machine424
Copy link
Contributor Author

/retest

@Tai-RedHat
Copy link

pr tested with cluster-bot

@machine424 machine424 mentioned this pull request Jul 10, 2024
Merged
4 tasks
@machine424
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance openshift/hypershift#4348

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@machine424: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@machine424
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance openshift/hypershift#4348

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/75d1c460-3ee1-11ef-8661-0cf1caa5fc92-0

@machine424
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance openshift/hypershift#4348

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/598fd4d0-3ef6-11ef-96f4-013c02769497-0

@machine424
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024
@machine424
MON-3921: Revert "Revert "Merge pull request openshift#2392 from mach…
8a65776 
…ine424/f-alert""

This reverts commit e1fc00b.

To re-introduce changes in openshift#2392

This will be merged once the new e2e-hypershift-conformance test is green.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024
@machine424
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance openshift/hypershift#4348

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 29, 2024

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/53aafae0-4d88-11ef-8cf8-0a6efb8fedbc-0

@machine424
Copy link
Contributor Author

/retest

@machine424
Copy link
Contributor Author

machine424 commented Jul 29, 2024 •
edited

@machine424: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

* periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/53aafae0-4d88-11ef-8cf8-0a6efb8fedbc-0

With the hypershift fix, shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured check in hypershift tests is no longer failing. (+ there are no RBAC issues logs on Prometheus')

strangely ci/prow/e2e-hypershift-conformance is also passing without the hypershift fix, the reason is that shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured may be checked before the alert is firing (I was expecting the check to run at the end)

@machine424
Copy link
Contributor Author

machine424 commented Jul 29, 2024 •
edited

/hold
until openshift/hypershift#4348 is merged.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
@machine424
Copy link
Contributor Author

/retest

@machine424
Copy link
Contributor Author

/hold cancel
openshift/hypershift#4348 was merged.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2024
@jan--f
Copy link
Contributor

jan--f commented Jul 30, 2024

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f15addc and 2 for PR HEAD 8a65776 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024 •
edited

@machine424: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions 8a65776 link false /test versions

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 32d3558 and 1 for PR HEAD 8a65776 in total

@machine424
Copy link
Contributor Author

/skip

@openshift-merge-bot openshift-merge-bot bot merged commit cb6f5b6 into openshift:master Aug 1, 2024
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmellado danielmellado Awaiting requested review from danielmellado

@slashpai slashpai Awaiting requested review from slashpai

Assignees

@jan--f jan--f

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@machine424 @openshift-ci-robot @Tai-RedHat @jan--f @openshift-merge-robot