[release-4.15] OCPBUGS-36563: add runbook_url annotations

[simonpasquier]

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[simonpasquier]

/jira cherrypick OCPBUGS-36482

[openshift-ci-robot]

@simonpasquier: Jira Issue OCPBUGS-36482 has been cloned as Jira Issue OCPBUGS-36563. Will retitle bug to link to clone.
/retitle OCPBUGS-36563: OCPBUGS-xxx: add runbook_url annotations

In response to this:

/jira cherrypick OCPBUGS-36482

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@simonpasquier: This pull request references Jira Issue OCPBUGS-36563, which is invalid:

• expected dependent Jira Issue OCPBUGS-36482 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[simonpasquier]

backport-risk-assessed

[simonpasquier]

/assign @jan--f

[jan--f]

/label backport-risk-assessed
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan--f, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jan--f,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[juzhao]

/jira refresh

[openshift-ci-robot]

@juzhao: This pull request references Jira Issue OCPBUGS-36563, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-36482 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-36482 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
• bug has dependents

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[juzhao]

compared with 4.16 PR: #2404
4.15 PR missed runbook_url annotations for TargetDown/PrometheusDuplicateTimestamps/KubeAggregatedAPIErrors alerts, these alerts exist in 4.15

# oc get clusterversion
NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.15.0-0.nightly-2024-07-04-091603   True        False         6h54m   Cluster version is 4.15.0-0.nightly-2024-07-04-091603

# oc -n openshift-monitoring get prometheusrules cluster-monitoring-operator-prometheus-rules -o jsonpath='{.spec.groups[*].rules[?(@.alert=="TargetDown")]}' | jq '{alert: .alert, runbook_url: .annotations.runbook_url}'
{
  "alert": "TargetDown",
  "runbook_url": null
}

# oc -n openshift-monitoring get prometheusrules prometheus-k8s-prometheus-rules -o jsonpath='{.spec.groups[*].rules[?(@.alert=="PrometheusDuplicateTimestamps")]}' | jq '{alert: .alert, runbook_url: .annotations.runbook_url}'
{
  "alert": "PrometheusDuplicateTimestamps",
  "runbook_url": null
}

# oc -n openshift-monitoring get prometheusrules kubernetes-monitoring-rules -o jsonpath='{.spec.groups[*].rules[?(@.alert=="KubeAggregatedAPIErrors")]}' | jq '{alert: .alert, runbook_url: .annotations.runbook_url}'
{
  "alert": "KubeAggregatedAPIErrors",
  "runbook_url": null
}

[simonpasquier]

@juzhao the runbook links for TargetDown, PrometheusDuplicateTimestamps and KubeAggregatedAPIErrors were added during the 4.16 dev cycle but not backported. If they should then it's another OCPBUGS ticket IMHO.

[juzhao]

/label cherry-pick-approved
/label qe-approved

[openshift-ci-robot]

@simonpasquier: This pull request references Jira Issue OCPBUGS-36563, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-36482 is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-36482 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
• bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@simonpasquier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@simonpasquier: Jira Issue OCPBUGS-36563: All pull requests linked via external trackers have merged:

• openshift/cluster-monitoring-operator#2406

Jira Issue OCPBUGS-36563 has been moved to the MODIFIED state.

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: cluster-monitoring-operator
This PR has been included in build cluster-monitoring-operator-container-v4.15.0-202407291038.p0.g2fa441a.assembly.stream.el9.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-07-29-185318