MON-3900: Remove prometheus-adapter code #2409
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@slashpai: This pull request references MON-3900 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
the
approved
slashpai
force-pushed
the
remove-adapter
branch
2 times, most recently
from
08675a9
to
5bbe871
Compare
| @@ -104,7 +104,7 @@ type AlertmanagerMainConfig struct { | |||
| } | |||
|
|
|||
| // The `K8sPrometheusAdapter` resource defines settings for the Prometheus Adapter component. | |||
| // This is deprecated and will be removed in a future version. | |||
| // This is deprecated config, setting this has no effect and will be removed in a future version. | |||
There was a problem hiding this comment.
Keeping this to check in 4.18 release if any user defined config exists in cmo's configmap and then block upgrades till removed
There was a problem hiding this comment.
Can you add a TODO comment? It doesn't have to be 4.18 "exactly" but setting a target is good.
slashpai
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/skip |
|
/retest-required |
slashpai
force-pushed
the
remove-adapter
branch
2 times, most recently
from
1c1afe0
to
f43831b
Compare
|
@simonpasquier could you please review again? |
|
Looks good! Happy to merge when CI and Simon are happy :) |
|
I will rebase once #2414 is merged to fix generate issue |
openshift-merge-robot
added
the
needs-rebase
This change removes prometheus-adapter code from CMO jsonnet: remove prometheus-adapter code pkg: remove prometheus-adapter code docs: remove prometheus-adapter refernces Signed-off-by: Jayapriya Pai <janantha@redhat.comn>
openshift-merge-robot
removed
the
needs-rebase
|
@slashpai: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] Distgit: cluster-monitoring-operator |
pkg: remove prometheus-adapter code