Allow scrapping of OpenStack load-balancer-id #2428
Conversation
Since kubernetes/kube-state-metrics#2145, kube-state-metrics does not collect `kube_*_annotations` metrics by default. It's no longer necessary to add them to the metrics' deny list. Removing `kube_*_annotations` from the deny list allows us to enable scrapping of annotation metrics via the `--metric-annotations-allowlist` option. Additionally, we were missing a comma, which might have been a problem in the comma-separated list of arguments.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In order to enable correlated metrics between OpenShift and the underlying platform, we need a way to map resources. We already have it for instances and volumes via the `kube_node_info` and `kube_persistentvolume_info` respectively, however we don't have the load-balancer ID in `kube_service_info`. For OpenStack, this mapping lives in the `loadbalancer.openstack.org/load-balancer-id` annotation in the service object. This patches enables scrapping OpenStack load-balancer-id, which can be found in the metric `kube_service_annotations`, label `annotation_loadbalancer_openstack_org_load_balancer_id`.
mandre
force-pushed
the
openstack-service-annotations
branch
from
116e957
to
284b1bb
Compare
|
/cc @rexagod |
|
I'm generally in favor of this, though I think we have yet another setting to gatekeep that should really be user accessible, similar to https://issues.redhat.com/browse/MON-2809. Iiuc we also no longer need to deny |
Yep, that's also my understanding I can do that in a separate PR if you'd like. |
|
@mandre: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing in favor of #2430. We want to use a more dynamic approach for collecting the needed annotation thanks to CRS. |
|
@mandre: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR is made of two separate changes.
The first one remove
kube_*_annotationsfrom the deny list, as it is no longer needed since kubernetes/kube-state-metrics#2145 and prevents the collection ofkube_*_annotations.The second change effectively enables scrapping of OpenStack load-balancer-id.