-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-24690: Disable network-node-identity on ROKS #2197
OCPBUGS-24690: Disable network-node-identity on ROKS #2197
Conversation
@kyrtapz: This pull request references Jira Issue OCPBUGS-24690, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@kyrtapz: This pull request references Jira Issue OCPBUGS-24690, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/lgtm |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold we need to talk about ROKS since the component is deployed and I'm not sure why we wouldn't want it to be deployed.
0421ad9
to
9b48adc
Compare
In environments with external control plane topology, the API server is deployed out of cluster. This means that CNO cannot easily predict how to deploy and enforce the node identity webhook. IBMCloud uses an external control plane topology with Calico as the CNI for both HyperShift based ROKS deployments and IBM ROKS Toolkit based ROKS deployments. There is no signifficant value added by the network-node-identity in this scenario. Signed-off-by: Patryk Diak <pdiak@redhat.com>
9b48adc
to
ad94f41
Compare
@kyrtapz: This pull request references Jira Issue OCPBUGS-24690, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/test images |
/retest-required |
…ogy clusters a5edddf introduced a change that doesn't work on non-hypershift clusters with external controllplane. Re-introduce the original logic for this type of clusters. Signed-off-by: Patryk Diak <pdiak@redhat.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/remove-hold
/lgtm
Thanks for being patient and working with us on these changes.
@rtheis: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, kyrtapz, rtheis, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-4.15 |
@kyrtapz: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
@kyrtapz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
/label acknowledge-critical-fixes-only |
c8debd9
into
openshift:master
@kyrtapz: Jira Issue OCPBUGS-24690: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-24690 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@kyrtapz: #2197 failed to apply on top of branch "release-4.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.16.0-202402191110.p0.gc8debd9.assembly.stream.el9 for distgit cluster-network-operator. |
Fix included in accepted release 4.16.0-0.nightly-2024-02-22-021321 |
Fix included in accepted release 4.16.0-0.nightly-2024-03-28-223620 |
In environments with external control plane topology, the API server is deployed out of cluster.
This means that CNO cannot easily predict how to deploy and enforce the node identity webhook.
IBMCloud uses an external control plane topology with Calico as the CNI for both HyperShift based ROKS deployments and IBM ROKS Toolkit based ROKS deployments.
/cc @dougbtv @s1061123