-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-30950: Set mount propagation to HostToContainer for /var/lib/kubelet #2368
Conversation
This PR is to change mountPropagation for /var/lib/kubelet mount from None to HostToContainer. This is to allow clean unmount of CSI Volumes. Jira: https://issues.redhat.com/browse/OCPBUGS-30950 Signed-off-by: Arnab Ghosh <arnabghosh89@gmail.com>
Hi @arghosh93. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@arghosh93: This pull request references Jira Issue OCPBUGS-30950, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label ok-to-test |
@kyrtapz: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest-required |
/retest |
/jira refresh |
@arghosh93: This pull request references Jira Issue OCPBUGS-30950, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@arghosh93 is this ready to go? should we look for reviewers at the SDN team meeting? |
/test e2e-vsphere-ovn-dualstack |
/test e2e-vsphere-ovn-dualstack-primaryv6 |
/test e2e-vsphere-ovn cluster init |
Yes @martinkennelly , its ready to be merged. |
@arghosh93 add to our team agenda to hopefully get into Jaimes backlog. We may need someone else if his plate is full. |
/cherry-pick release-4.16 |
@arghosh93: only openshift org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Decided at team meeting to wait until critical fixes only label requirement is removed. |
@martinkennelly / @arghosh93 : let's move ahead with this, ? |
/test okd-scos-images |
Jaime will review. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arghosh93, jcaamano, martinkennelly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/retest |
/hold cancel |
@arghosh93: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cef4af3
into
openshift:master
@arghosh93: Jira Issue OCPBUGS-30950: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-30950 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@arghosh93: new pull request created: #2430 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build cluster-network-operator-container-v4.17.0-202407041843.p0.gcef4af3.assembly.stream.el9 for distgit cluster-network-operator. |
This PR is to change mountPropagation for /var/lib/kubelet mount from None to HostToContainer. This is to allow clean unmount of CSI Volumes.
Jira: https://issues.redhat.com/browse/OCPBUGS-30950