Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDN-4916: Bump to k8s v1.30 latest #2429

Merged
merged 1 commit into from
Jul 5, 2024
Merged

SDN-4916: Bump to k8s v1.30 latest #2429

merged 1 commit into from
Jul 5, 2024

Conversation

jcaamano
Copy link
Contributor

@jcaamano jcaamano commented Jul 4, 2024

Refer to commit messages for detailed steps taken.

Replaces: #2423

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 4, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 4, 2024 •
edited by openshift-ci bot
Loading

@jcaamano: This pull request references SDN-4916 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to this:

Refer to commit messages for detailed steps taken.

Replaces: #2423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from abhat and cybertron July 4, 2024 15:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@jcaamano jcaamano force-pushed the bump-k8s-v0.30 branch 2 times, most recently from 67dffeb to ec1afc1 Compare July 4, 2024 16:58
@kyrtapz
Copy link
Contributor

kyrtapz commented Jul 5, 2024

/retest

kyrtapz
kyrtapz reviewed Jul 5, 2024
View reviewed changes
pkg/controller/clusterconfig/clusterconfig_controller.go Outdated
@@ -43,7 +44,7 @@ func add(mgr manager.Manager, r reconcile.Reconciler) error {
}

// Watch for changes to primary resource config.openshift.io/v1/Network
err = c.Watch(source.Kind(mgr.GetCache(), &configv1.Network{}), &handler.EnqueueRequestForObject{}, predicate.GenerationChangedPredicate{})
err = c.Watch(source.Kind[client.Object](mgr.GetCache(), &configv1.Network{}, &handler.EnqueueRequestForObject{}, predicate.GenerationChangedPredicate{}))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with other files can we use a crclient alias for sigs.k8s.io/controller-runtime/pkg/client?

@kyrtapz
Copy link
Contributor

kyrtapz commented Jul 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@jcaamano
Bump to k8s v1.30 latest
c3d2abe 
go get k8s.io/api@v0.30.2
go get k8s.io/code-generator@v0.30.2
go get k8s.io/component-base@v0.30.2
go get k8s.io/kube-proxy@v0.30.2
go get k8s.io/apiextensions-apiserver@v0.30.2
go get github.com/openshift/build-machinery-go
go get github.com/openshift/api
go get github.com/openshift/client-go
go get github.com/openshift/library-go
go get github.com/openshift/machine-config-operator
go get k8s.io/kube-aggregator@v0.30.2
go get sigs.k8s.io/apiserver-network-proxy/konnectivity-client@v0.30.3
go get k8s.io/utils
go get sigs.k8s.io/controller-runtime@v0.18.4
go mod vendor
go mod tidy

Fix API changes

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@kyrtapz
Copy link
Contributor

kyrtapz commented Jul 5, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD cef4af3 and 2 for PR HEAD c3d2abe in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 5, 2024

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-hypershift-ovn-kubevirt c3d2abe link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-vsphere-ovn c3d2abe link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-dualstack c3d2abe link false /test e2e-vsphere-ovn-dualstack
ci/prow/4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade c3d2abe link false /test 4.17-upgrade-from-stable-4.16-e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-serial c3d2abe link false /test e2e-aws-ovn-serial
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 c3d2abe link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-openstack-ovn c3d2abe link false /test e2e-openstack-ovn
ci/prow/4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade c3d2abe link false /test 4.17-upgrade-from-stable-4.16-e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-single-node c3d2abe link false /test e2e-aws-ovn-single-node
ci/prow/security c3d2abe link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e3fd660 into openshift:master Jul 5, 2024
24 of 34 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-network-operator-container-v4.17.0-202407051811.p0.ge3fd660.assembly.stream.el9 for distgit cluster-network-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyrtapz kyrtapz kyrtapz left review comments

@abhat abhat Awaiting requested review from abhat

@cybertron cybertron Awaiting requested review from cybertron

Assignees

@kyrtapz kyrtapz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcaamano @openshift-ci-robot @kyrtapz @openshift-bot