SDN-4930: UDN: Allow access to default/kubernetes and openshift-dns/dns-default #2492

kyrtapz · 2024-09-05T14:31:20Z

This has to wait for openshift/ovn-kubernetes#2314

openshift-ci · 2024-09-05T14:31:26Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2024-10-31T16:01:01Z

@kyrtapz: This pull request references SDN-4930 which is a valid jira issue.

In response to this:

This has to wait for openshift/ovn-kubernetes#2314

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kyrtapz · 2024-10-31T16:01:27Z

@trozet @tssurya ptal

kyrtapz · 2024-10-31T16:01:48Z

/test ?

openshift-ci · 2024-10-31T16:01:52Z

@kyrtapz: The following commands are available to trigger required jobs:

/test 4.18-upgrade-from-stable-4.17-images
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-windows
/test e2e-azure-ovn-upgrade
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test images
/test lint
/test unit
/test verify

The following commands are available to trigger optional jobs:

/test 4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
/test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
/test 4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-upgrade
/test e2e-aws-hypershift-ovn-kubevirt
/test e2e-aws-ovn-ipsec-serial
/test e2e-aws-ovn-ipsec-upgrade
/test e2e-aws-ovn-local-to-shared-gateway-mode-migration
/test e2e-aws-ovn-serial
/test e2e-aws-ovn-shared-to-local-gateway-mode-migration
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-techpreview-serial
/test e2e-azure-ovn
/test e2e-azure-ovn-dualstack
/test e2e-azure-ovn-manual-oidc
/test e2e-gcp-ovn-techpreview
/test e2e-metal-ipi-ovn-ipv6-ipsec
/test e2e-network-mtu-migration-ovn-ipv4
/test e2e-network-mtu-migration-ovn-ipv6
/test e2e-openstack-ovn
/test e2e-ovn-hybrid-step-registry
/test e2e-ovn-ipsec-step-registry
/test e2e-ovn-step-registry
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-dualstack
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-windows
/test okd-scos-images
/test qe-perfscale-aws-ovn-medium-cluster-density
/test qe-perfscale-aws-ovn-medium-node-density-cni
/test qe-perfscale-aws-ovn-small-cluster-density
/test qe-perfscale-aws-ovn-small-node-density-cni
/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-network-operator-master-4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade
pull-ci-openshift-cluster-network-operator-master-4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade
pull-ci-openshift-cluster-network-operator-master-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-upgrade
pull-ci-openshift-cluster-network-operator-master-4.18-upgrade-from-stable-4.17-images
pull-ci-openshift-cluster-network-operator-master-e2e-aws-hypershift-ovn-kubevirt
pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-hypershift-conformance
pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-local-to-shared-gateway-mode-migration
pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-serial
pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-shared-to-local-gateway-mode-migration
pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-single-node
pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-upgrade
pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-windows
pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn
pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn-upgrade
pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn
pull-ci-openshift-cluster-network-operator-master-e2e-gcp-ovn-upgrade
pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6-ipsec
pull-ci-openshift-cluster-network-operator-master-e2e-network-mtu-migration-ovn-ipv4
pull-ci-openshift-cluster-network-operator-master-e2e-network-mtu-migration-ovn-ipv6
pull-ci-openshift-cluster-network-operator-master-e2e-openstack-ovn
pull-ci-openshift-cluster-network-operator-master-e2e-ovn-hybrid-step-registry
pull-ci-openshift-cluster-network-operator-master-e2e-ovn-ipsec-step-registry
pull-ci-openshift-cluster-network-operator-master-e2e-ovn-step-registry
pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn
pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack
pull-ci-openshift-cluster-network-operator-master-e2e-vsphere-ovn-dualstack-primaryv6
pull-ci-openshift-cluster-network-operator-master-images
pull-ci-openshift-cluster-network-operator-master-lint
pull-ci-openshift-cluster-network-operator-master-security
pull-ci-openshift-cluster-network-operator-master-unit
pull-ci-openshift-cluster-network-operator-master-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kyrtapz · 2024-10-31T16:02:18Z

/test e2e-gcp-ovn-techpreview

tssurya

/lgtm

these changes worked pretty well for me on my demo cluster setup

tssurya · 2024-11-04T09:32:34Z

bindata/network/ovn-kubernetes/managed/004-config.yaml

@@ -108,6 +109,7 @@ data:
    encap-port="{{.GenevePort}}"
    enable-lflow-cache=true
    lflow-cache-limit-kb=1048576
+    udn-allowed-default-services="default/kubernetes,openshift-dns/dns-default"


does cluster-manager need this in hypershift?

Not today, I wanted to keep it the same for any unforeseen use cases in the future.

tssurya · 2024-11-04T09:33:30Z

/lgtm cancel
lol unit tests need to be updated but regardless the changes logic seems OK to me

Signed-off-by: Patryk Diak <pdiak@redhat.com>

kyrtapz · 2024-11-04T13:34:17Z

/lgtm cancel lol unit tests need to be updated but regardless the changes logic seems OK to me

🤦
I've fixed the tests.

tssurya

/lgtm

openshift-ci · 2024-11-04T14:08:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-11-04T17:08:20Z

/retest-required

Remaining retests: 0 against base HEAD 4e7def6 and 2 for PR HEAD 5db6378 in total

openshift-ci-robot · 2024-11-04T20:28:27Z

/retest-required

Remaining retests: 0 against base HEAD 4e7def6 and 2 for PR HEAD 5db6378 in total

openshift-ci-robot · 2024-11-05T02:10:30Z

/retest-required

Remaining retests: 0 against base HEAD 4e7def6 and 2 for PR HEAD 5db6378 in total

kyrtapz · 2024-11-05T08:44:03Z

/retest-required

openshift-ci · 2024-11-05T12:35:06Z

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-hypershift-ovn-kubevirt	`5db6378`	link	false	`/test e2e-aws-hypershift-ovn-kubevirt`
ci/prow/4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade	`5db6378`	link	false	`/test 4.18-upgrade-from-stable-4.17-e2e-aws-ovn-upgrade`
ci/prow/e2e-aws-ovn-shared-to-local-gateway-mode-migration	`5db6378`	link	false	`/test e2e-aws-ovn-shared-to-local-gateway-mode-migration`
ci/prow/4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-upgrade	`5db6378`	link	false	`/test 4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-upgrade`
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec	`5db6378`	link	false	`/test e2e-metal-ipi-ovn-ipv6-ipsec`
ci/prow/4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade	`5db6378`	link	false	`/test 4.18-upgrade-from-stable-4.17-e2e-azure-ovn-upgrade`
ci/prow/e2e-aws-ovn-single-node	`5db6378`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-vsphere-ovn	`5db6378`	link	false	`/test e2e-vsphere-ovn`
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	`5db6378`	link	false	`/test e2e-vsphere-ovn-dualstack-primaryv6`
ci/prow/security	`5db6378`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-11-05T18:30:33Z

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.18.0-202411051638.p0.gfff6ea5.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024

kyrtapz force-pushed the udn_default_svcs branch from 70dfb0c to 7e5bffe Compare September 20, 2024 15:18

kyrtapz changed the title ~~UDN: Allow access to kubernetes/default and dns-default/openshift-dns~~ UDN: Allow access to default/kubernetes and openshift-dns/dns-default Sep 20, 2024

kyrtapz marked this pull request as ready for review October 31, 2024 16:00

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2024

kyrtapz changed the title ~~UDN: Allow access to default/kubernetes and openshift-dns/dns-default~~ SDN-4930: UDN: Allow access to default/kubernetes and openshift-dns/dns-default Oct 31, 2024

openshift-ci bot requested review from abhat and JacobTanenbaum October 31, 2024 16:00

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 31, 2024

kyrtapz mentioned this pull request Oct 31, 2024

SDN-4930: Verify that a UDN pod can reach the kapi service in the default network openshift/origin#29253

Open

tssurya approved these changes Nov 4, 2024

View reviewed changes

openshift-ci bot assigned tssurya Nov 4, 2024

openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 4, 2024

UDN: Allow access to kubernetes/default and dns-default/openshift-dns

5db6378

Signed-off-by: Patryk Diak <pdiak@redhat.com>

kyrtapz force-pushed the udn_default_svcs branch from 7e5bffe to 5db6378 Compare November 4, 2024 13:31

tssurya approved these changes Nov 4, 2024

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024

openshift-merge-bot bot merged commit fff6ea5 into openshift:master Nov 5, 2024
23 of 33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDN-4930: UDN: Allow access to default/kubernetes and openshift-dns/dns-default #2492

SDN-4930: UDN: Allow access to default/kubernetes and openshift-dns/dns-default #2492

kyrtapz commented Sep 5, 2024 •

edited

Loading

openshift-ci bot commented Sep 5, 2024

openshift-ci-robot commented Oct 31, 2024 •

edited by openshift-ci bot

Loading

kyrtapz commented Oct 31, 2024

kyrtapz commented Oct 31, 2024

openshift-ci bot commented Oct 31, 2024

kyrtapz commented Oct 31, 2024

tssurya left a comment

tssurya Nov 4, 2024

kyrtapz Nov 4, 2024

tssurya commented Nov 4, 2024 •

edited

Loading

kyrtapz commented Nov 4, 2024

tssurya left a comment

openshift-ci bot commented Nov 4, 2024

openshift-ci-robot commented Nov 4, 2024

openshift-ci-robot commented Nov 4, 2024

openshift-ci-robot commented Nov 5, 2024

kyrtapz commented Nov 5, 2024

openshift-ci bot commented Nov 5, 2024

openshift-bot commented Nov 5, 2024

SDN-4930: UDN: Allow access to default/kubernetes and openshift-dns/dns-default #2492

SDN-4930: UDN: Allow access to default/kubernetes and openshift-dns/dns-default #2492

Conversation

kyrtapz commented Sep 5, 2024 • edited Loading

openshift-ci bot commented Sep 5, 2024

openshift-ci-robot commented Oct 31, 2024 • edited by openshift-ci bot Loading

kyrtapz commented Oct 31, 2024

kyrtapz commented Oct 31, 2024

openshift-ci bot commented Oct 31, 2024

kyrtapz commented Oct 31, 2024

tssurya left a comment

Choose a reason for hiding this comment

tssurya Nov 4, 2024

Choose a reason for hiding this comment

kyrtapz Nov 4, 2024

Choose a reason for hiding this comment

tssurya commented Nov 4, 2024 • edited Loading

kyrtapz commented Nov 4, 2024

tssurya left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Nov 4, 2024

openshift-ci-robot commented Nov 4, 2024

openshift-ci-robot commented Nov 4, 2024

openshift-ci-robot commented Nov 5, 2024

kyrtapz commented Nov 5, 2024

openshift-ci bot commented Nov 5, 2024

openshift-bot commented Nov 5, 2024

kyrtapz commented Sep 5, 2024 •

edited

Loading

openshift-ci-robot commented Oct 31, 2024 •

edited by openshift-ci bot

Loading

tssurya commented Nov 4, 2024 •

edited

Loading