-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Refactor controller runtime #289
WIP: Refactor controller runtime #289
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cynepco3hahue The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
da84407
to
1a7b5cd
Compare
|
||
const ClusterOperatorName = "node-tuning" | ||
|
||
// Reconciler reconciles a Tuned object and creates the tuned daemon set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ment for the CO and not tuned object I assume
pkg/operator/reconciler.go
Outdated
return reconcile.Result{}, nil | ||
} | ||
|
||
func (r *Reconciler) syncDaemonSet() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be removed from the current controller and handled in the CVO controller ?
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
1a7b5cd
to
e1116d5
Compare
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
ded8226
to
1ca3514
Compare
Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
- use golang 1.17 - fix the copy directive Signed-off-by: Artyom Lukianov <alukiano@redhat.com>
1ca3514
to
c2ade74
Compare
/retest |
@cynepco3hahue: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cynepco3hahue you can close this PR in favor of #302 |
Close in favor of #302 |
No description provided.