Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1872080: move templates to RHEL/CentOS/UBI 8 imagestream tags #320

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Bug 1872080: move templates to RHEL/CentOS/UBI 8 imagestream tags #320

merged 1 commit into from
Sep 11, 2020

Conversation

yselkowitz
Copy link
Contributor

This also updates Fuse samples to 7.7.

/assign @gabemontero

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 3, 2020
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: move templates to RHEL/CentOS/UBI 8 imagestream tags

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 3, 2020
@gabemontero
Copy link
Contributor

/approve

waiting on at least some of the multitude of e2e's to come back prior to LGTM

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@gabemontero
Copy link
Contributor

There is a problem with the mariadb imagestream @yselkowitz pulling registry.redhat.io/rhel8/mariadb-103:latest in e2e-aws-image-ecosystem.

    - conditions:
      - generation: 2
        lastTransitionTime: "2020-09-03T16:20:25Z"
        message: you may not have access to the container image "registry.redhat.io/rhel8/mariadb-103:latest"
        reason: Unauthorized
        status: "False"
        type: ImportSuccess
      items: null
      tag: 10.3-el8

I can pull it locally so it appears to be a registry.redhat.io flake. I've heard through the grapevine there have been issues pulling images from there today in other PRs / e2e's

We are going to have to wade through those before getting this merged.

@gabemontero
Copy link
Contributor

/retest

@yselkowitz
Copy link
Contributor Author

Found an issue with dancer-ex
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2020
@yselkowitz yselkowitz mentioned this pull request Sep 4, 2020
Closed
@gabemontero
Copy link
Contributor

seeing if any of the okd e2e's pass (ignoring the still pending upstream dancer-ex change)

/retest

@yselkowitz
Copy link
Contributor Author

Looks like not. What's the problem?

@gabemontero
Copy link
Contributor

hey @vrutkovs .... in the last week or so we've seen the OKD e2e's across the board fail with various install/bootstrap types of failures?

Is this a known situation?

If not, can you take a look at some of the recent failures here and see if some mitigations can be initiated?

If the outlook for fixing this is not "soon", I'm going to be inclined to change the OKD e2e's for samples operator to optional, and override the failures for this PR.

thanks

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 11, 2020
Merged
@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

I've pulled in the dotnet template removal from the library, and the dancer template update in advance. New problem or something wrong with the latest changes?

@yselkowitz
assets: full sync from library
4c499df 
This pulls in the following changes:
* Add UBI 8 tags to dotnet and java imagestreams
* SCL templates (aside from nodejs) use RHEL/CentOS/UBI 8 imagestream tags
* Remove unmaintained dotnet templates
* Fuse updated to 7.7
@yselkowitz
Copy link
Contributor Author

Resynced from the library, picking up the dotnet and dancer changes.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2020
@gabemontero
Copy link
Contributor

for the non-okd's there looks to be CI level unhappiness and the e2e's are not getting off the ground ... we'll just have to wait those out.

if we don't hear from @vrutkovs by this afternoon US eastern time I'll probably pull the trigger on making those OKD jobs optional.

@yselkowitz
Copy link
Contributor Author

Looks like the overall issues have been sorted out, only the OKD tests show as failing now.

@yselkowitz
Copy link
Contributor Author

And it looks like the OKD tests are already optional, there is no (Required) next to any of them.

@vrutkovs
Copy link
Member

OKD install is broken, feel free to /skip those - we'll verify imagestreams are correct later

@gabemontero
Copy link
Contributor

OKD install is broken, feel free to /skip those - we'll verify imagestreams are correct later

thanks @vrutkovs

I now also see the jobs are marked optional in openshift/release

/skip ci/prow/okd-e2e-aws

@gabemontero
Copy link
Contributor

/override ci/prow/okd-e2e-aws

@openshift-ci-robot
Copy link
Contributor

@gabemontero: Overrode contexts on behalf of gabemontero: ci/prow/okd-e2e-aws

In response to this:

/override ci/prow/okd-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

/override ci/prow/okd-e2e-aws-builds
/override ci/prow/okd-e2e-aws-image-ecosystem
/override ci/prow/okd-e2e-aws-jenkins
/override ci/prow/okd-e2e-aws-operator
/override ci/prow/okd-e2e-aws-upgrade
/override ci/prow/okd-unit

@openshift-ci-robot
Copy link
Contributor

@gabemontero: Overrode contexts on behalf of gabemontero: ci/prow/okd-e2e-aws-builds, ci/prow/okd-e2e-aws-image-ecosystem, ci/prow/okd-e2e-aws-jenkins, ci/prow/okd-e2e-aws-operator, ci/prow/okd-e2e-aws-upgrade, ci/prow/okd-unit

In response to this:

/override ci/prow/okd-e2e-aws-builds
/override ci/prow/okd-e2e-aws-image-ecosystem
/override ci/prow/okd-e2e-aws-jenkins
/override ci/prow/okd-e2e-aws-operator
/override ci/prow/okd-e2e-aws-upgrade
/override ci/prow/okd-unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 14d1ed1 into openshift:master Sep 11, 2020
@openshift-ci-robot
Copy link
Contributor

@yselkowitz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

In response to this:

Bug 1872080: move templates to RHEL/CentOS/UBI 8 imagestream tags

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 14, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage Awaiting requested review from dmage

@gabemontero gabemontero Awaiting requested review from gabemontero

Assignees

@gabemontero gabemontero

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yselkowitz @openshift-ci-robot @gabemontero @vrutkovs @openshift-merge-robot