Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SO-119: Fix mariadb import url in OKD #525

Merged

Conversation

LorbusChris
Copy link
Member

@LorbusChris LorbusChris commented Dec 4, 2023

OKD tests are currently broken due to imagestream samples introduced in the recent sync containing invalid image import URLs.
This PR contains changes from:

@fbm3307
Copy link
Contributor

fbm3307 commented Dec 4, 2023

Maria DB is a Non S2i Samples and OKD . we have already done the release sync for 4.15 and wont merge this PR in Samples Operater.

@LorbusChris
Copy link
Member Author

Samples Operator will have to be fixed, as this invalid url breaks OKD build testing.
Another way would be to merge sclorg/mariadb-container#220 and sync again.
Happy to open a Jira ticket if needed.

@fbm3307
Copy link
Contributor

fbm3307 commented Dec 4, 2023

Samples Operator will have to be fixed, as this invalid url breaks OKD build testing. Another way would be to merge sclorg/mariadb-container#220 and sync again. Happy to open a Jira ticket if needed.

This was communicated way before that changes wouldn't be accepted starting ocp 4.15, i hope there is a plan in place for future to decouple this from Samples operator as we are going to remove the assests folder itself We are Downsizing CSO. May be even if i merge it this time, the release process is already done for samples side if that is not your concern i can try checking about this

@LorbusChris
Copy link
Member Author

LorbusChris commented Dec 4, 2023

This change does not concern OCP. It concerns OKD. Both are built from the same codebase, but the manifest changed here is OKD-only. This is critical to fix builds here: https://origin-release.ci.openshift.org/#4.15.0-0.okd-scos

@fbm3307
Copy link
Contributor

fbm3307 commented Dec 5, 2023

/retest-required

@vrutkovs
Copy link
Member

vrutkovs commented Dec 5, 2023

/retitle SO-119: Fix mariadb import url in OKD

@openshift-ci openshift-ci bot changed the title Fix mariadb import url in OKD SO-119: Fix mariadb import url in OKD Dec 5, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 5, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 5, 2023

@LorbusChris: This pull request references SO-119 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

OKD tests are currently broken due to imagestream samples introduced in the recent sync containing invalid image import URLs.
This PR contains changes from:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Member Author

/test okd-scos-e2e-aws-ovn

1 similar comment
@LorbusChris
Copy link
Member Author

/test okd-scos-e2e-aws-ovn

@LorbusChris
Copy link
Member Author

/test okd-e2e-aws-ovn

Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

@LorbusChris: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn-builds 865b8ed link false /test okd-scos-e2e-aws-ovn-builds
ci/prow/okd-e2e-aws-ovn-upgrade 865b8ed link false /test okd-e2e-aws-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn-upgrade 865b8ed link false /test okd-scos-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-operator 865b8ed link false /test okd-e2e-aws-operator
ci/prow/okd-e2e-aws-ovn-builds 865b8ed link false /test okd-e2e-aws-ovn-builds
ci/prow/okd-e2e-aws-ovn-jenkins 865b8ed link false /test okd-e2e-aws-ovn-jenkins
ci/prow/okd-e2e-aws-ovn-image-ecosystem 865b8ed link false /test okd-e2e-aws-ovn-image-ecosystem
ci/prow/okd-scos-e2e-aws-ovn-image-ecosystem 865b8ed link false /test okd-scos-e2e-aws-ovn-image-ecosystem

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@LorbusChris
Copy link
Member Author

@fbm3307 tests are passing, could you take a look again? This is critical to get the OKD integration stream builds fixed on master.

@fbm3307
Copy link
Contributor

fbm3307 commented Dec 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit aa379b2 into openshift:master Dec 6, 2023
19 of 27 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-samples-operator-container-v4.16.0-202312061931.p0.gaa379b2.assembly.stream for distgit ose-cluster-samples-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants