Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-28230: add FallbackToLogsOnError for easier debugging #532

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jan 25, 2024

All openshift operators must include FallbackToLogsOnError to ease debugging.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 25, 2024
@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request references Jira Issue OCPBUGS-28230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

All openshift operators must include FallbackToLogsOnError to ease debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 29, 2024

/retest-required

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 30, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn-builds acd6ee4 link false /test okd-scos-e2e-aws-ovn-builds
ci/prow/okd-scos-e2e-aws-ovn-jenkins acd6ee4 link false /test okd-scos-e2e-aws-ovn-jenkins
ci/prow/okd-scos-e2e-aws-ovn-image-ecosystem acd6ee4 link false /test okd-scos-e2e-aws-ovn-image-ecosystem
ci/prow/okd-scos-e2e-aws-ovn acd6ee4 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn-upgrade acd6ee4 link false /test okd-scos-e2e-aws-ovn-upgrade
ci/prow/okd-e2e-aws-ovn-image-ecosystem acd6ee4 link false /test okd-e2e-aws-ovn-image-ecosystem
ci/prow/okd-scos-e2e-aws-operator acd6ee4 link false /test okd-scos-e2e-aws-operator
ci/prow/okd-e2e-aws-ovn acd6ee4 link false /test okd-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fbm3307
Copy link
Contributor

fbm3307 commented Jan 30, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, fbm3307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@deads2k deads2k added qe-approved Signifies that QE has signed off on this PR px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. labels Jan 31, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7d6dcb2 into openshift:master Jan 31, 2024
19 of 27 checks passed
@openshift-ci-robot
Copy link
Contributor

@deads2k: Jira Issue OCPBUGS-28230: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-28230 has not been moved to the MODIFIED state.

In response to this:

All openshift operators must include FallbackToLogsOnError to ease debugging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-samples-operator-container-v4.16.0-202401311812.p0.g7d6dcb2.assembly.stream for distgit ose-cluster-samples-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants