Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2043130: Update CSI sidecars to the latest release for 4.10 #256

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jan 20, 2022

This adds the new required RBAC rules for external-snapshotter v5.0.1:

  • volumesnapshotcontents:patch
  • volumesnapshotcontents/status:patch (already existed)
  • volumesnapshots:patch
  • volumesnapshots/status:patch

See openshift/csi-external-snapshotter#66
/cc @openshift/storage

This adds the new required RBAC rules for external-snapshotter v5.0.1
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@dobsonj: This pull request references Bugzilla bug 2043130, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

Bug 2043130: Update CSI sidecars to the latest release for 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2022
@dobsonj
Copy link
Member Author

dobsonj commented Jan 21, 2022

/retest

@bertinatto
Copy link
Member

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

@dobsonj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-file-csi 4deeb7f link false /test e2e-azure-file-csi
ci/prow/e2e-azure-csi 4deeb7f link false /test e2e-azure-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member Author

dobsonj commented Jan 24, 2022

The test failures in e2e-azure-csi and e2e-azure-file-csi are due to:
https://bugzilla.redhat.com/show_bug.cgi?id=2040793
https://bugzilla.redhat.com/show_bug.cgi?id=2042960

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5765863 into openshift:master Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@dobsonj: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2043130 has not been moved to the MODIFIED state.

In response to this:

Bug 2043130: Update CSI sidecars to the latest release for 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants