OCPBUGS-26022: always validate container names for proxy injection #1014

sjenning · 2024-01-03T16:16:15Z

would prevent escapes like this https://issues.redhat.com//browse/OCPBUGS-26001

openshift-ci · 2024-01-03T16:16:22Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2024-01-03T16:16:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sjenning
Once this PR has been reviewed and has the lgtm label, please assign lalatendumohanty for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-01-03T19:12:58Z

@sjenning: This pull request references Jira Issue OCPBUGS-26022, which is invalid:

expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

would prevent escapes like this https://issues.redhat.com//browse/OCPBUGS-26001

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sjenning · 2024-01-03T19:13:31Z

/jira refresh

openshift-ci-robot · 2024-01-03T19:13:37Z

@sjenning: This pull request references Jira Issue OCPBUGS-26022, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.0) matches configured target version for branch (4.16.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wking · 2024-01-03T20:56:27Z

lib/resourcebuilder/podspec.go

+				podSpec.InitContainers[i].Env = append(podSpec.InitContainers[i].Env, corev1.EnvVar{Name: "HTTP_PROXY", Value: httpProxy})
+				podSpec.InitContainers[i].Env = append(podSpec.InitContainers[i].Env, corev1.EnvVar{Name: "HTTPS_PROXY", Value: httpsProxy})
+				podSpec.InitContainers[i].Env = append(podSpec.InitContainers[i].Env, corev1.EnvVar{Name: "NO_PROXY", Value: noProxy})
+			}
 		}

 		if !found {


Trying to test with Cluster Bot launch 4.16,openshift/cluster-version-operator#1014,openshift/console-operator#832 gcp (logs), the cluster installed fine, and I see no sign of the expected line in CVO logs:

$ oc -n openshift-cluster-version logs -l k8s-app=cluster-version-operator --tail -1 | grep -c 'requested injection for non-existent container' 0

Not yet clear to me what's going on.

@wking I tested it with a new PR which has busted manifest, and launch command failed, my launch command is:
launch 4.16,openshift/cluster-version-operator#1014,openshift/console-operator#874 gcp

full log can be found in https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-gcp-modern/1763113136023408640

openshift-ci · 2024-01-03T21:28:51Z

@sjenning: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agnostic-ovn-upgrade-out-of-change	`e252583`	link	true	`/test e2e-agnostic-ovn-upgrade-out-of-change`
ci/prow/e2e-agnostic-ovn-upgrade-into-change	`e252583`	link	true	`/test e2e-agnostic-ovn-upgrade-into-change`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-06-03T09:00:52Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2024-07-04T00:30:49Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2024-08-09T00:00:59Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2024-08-09T00:01:09Z

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2024-08-09T00:01:14Z

@sjenning: This pull request references Jira Issue OCPBUGS-26022. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

would prevent escapes like this https://issues.redhat.com//browse/OCPBUGS-26001

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2024

always validate container names for proxy injection

e252583

sjenning force-pushed the validation-proxy-inject-container-names branch from fc50464 to e252583 Compare January 3, 2024 16:28

sjenning marked this pull request as ready for review January 3, 2024 19:07

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2024

openshift-ci bot requested review from Davoska and wking January 3, 2024 19:09

sjenning changed the title ~~always validate container names for proxy injection~~ OCPBUGS-26022: always validate container names for proxy injection Jan 3, 2024

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 3, 2024

openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 3, 2024

openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 3, 2024

openshift-ci bot requested a review from jiajliu January 3, 2024 19:13

wking mentioned this pull request Jan 3, 2024

WIP: Revert "Revert #822 "OCPBUGS-15827: Update console conversion webhook server to use sig.k8s.io certwatcher"" openshift/console-operator#832

Closed

wking reviewed Jan 3, 2024

View reviewed changes

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2024

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 4, 2024

openshift-ci bot closed this Aug 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-26022: always validate container names for proxy injection #1014

OCPBUGS-26022: always validate container names for proxy injection #1014

sjenning commented Jan 3, 2024 •

edited

Loading

openshift-ci bot commented Jan 3, 2024

openshift-ci bot commented Jan 3, 2024

openshift-ci-robot commented Jan 3, 2024

sjenning commented Jan 3, 2024

openshift-ci-robot commented Jan 3, 2024

wking Jan 3, 2024

JianLi-RH Mar 5, 2024

openshift-ci bot commented Jan 3, 2024 •

edited

Loading

openshift-bot commented Jun 3, 2024

openshift-bot commented Jul 4, 2024

openshift-bot commented Aug 9, 2024

openshift-ci bot commented Aug 9, 2024

openshift-ci-robot commented Aug 9, 2024

OCPBUGS-26022: always validate container names for proxy injection #1014

OCPBUGS-26022: always validate container names for proxy injection #1014

Conversation

sjenning commented Jan 3, 2024 • edited Loading

openshift-ci bot commented Jan 3, 2024

openshift-ci bot commented Jan 3, 2024

openshift-ci-robot commented Jan 3, 2024

sjenning commented Jan 3, 2024

openshift-ci-robot commented Jan 3, 2024

wking Jan 3, 2024

Choose a reason for hiding this comment

JianLi-RH Mar 5, 2024

Choose a reason for hiding this comment

openshift-ci bot commented Jan 3, 2024 • edited Loading

openshift-bot commented Jun 3, 2024

openshift-bot commented Jul 4, 2024

openshift-bot commented Aug 9, 2024

openshift-ci bot commented Aug 9, 2024

openshift-ci-robot commented Aug 9, 2024

sjenning commented Jan 3, 2024 •

edited

Loading

openshift-ci bot commented Jan 3, 2024 •

edited

Loading