Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-MERGE] Update Status Controller #1060

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

petr-muller
Copy link
Member

  • Bump openshift/api
  • configv1.FeatureGateUpgradeStatus -> features.FeatureGateUpgradeStatus
  • Bump openshift/library-go
  • Pick up zz_generated.crd-manifests
  • Use pre-merge o/api with UpdateStatus

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2024
Copy link
Contributor

openshift-ci bot commented Jun 22, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jun 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@petr-muller
Copy link
Member Author

/test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2024
@petr-muller
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

Copy link
Contributor

openshift-ci bot commented Jun 22, 2024

@petr-muller: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f0d20240-30ba-11ef-8ea0-38515772df15-0

@petr-muller
Copy link
Member Author

/payload-job periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

Copy link
Contributor

openshift-ci bot commented Jun 22, 2024

@petr-muller: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn
  • periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8dcea940-30c0-11ef-9276-f698ba7e20de-0

@petr-muller
Copy link
Member Author

/test all

@petr-muller petr-muller force-pushed the update-status-operator branch 3 times, most recently from 33f4334 to ba3e7c4 Compare June 27, 2024 21:20
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2024
@petr-muller
Copy link
Member Author

/test all

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

@petr-muller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-upgrade-out-of-change 7c6886f link true /test e2e-agnostic-ovn-upgrade-out-of-change
ci/prow/lint 7c6886f link true /test lint
ci/prow/e2e-hypershift-conformance 7c6886f link true /test e2e-hypershift-conformance
ci/prow/e2e-aws-ovn-techpreview 7c6886f link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-agnostic-operator 7c6886f link true /test e2e-agnostic-operator
ci/prow/e2e-agnostic-ovn 7c6886f link true /test e2e-agnostic-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2024
@petr-muller petr-muller force-pushed the update-status-operator branch 3 times, most recently from d88e339 to 947aff1 Compare July 26, 2024 14:48
@petr-muller petr-muller force-pushed the update-status-operator branch 2 times, most recently from 3634942 to 51e625a Compare August 22, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants