Bug 1872080: Updating Dockerfile.rhel7 baseimages to match ocp-build-data config #442
Conversation
This PR is autogenerated by the [ocp-build-data-enforcer][1]. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository][2] used for producing release artifacts. If you believe the content of this PR is incorrect, please contact the dptp team in #forum-testplatform. [1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer [2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
|
/uncc |
openshift-ci-robot
requested review from
LalatenduMohanty
and removed request for
sdodson
jupierce
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@openshift-bot: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci-robot
added
lgtm
wking
changed the title
| @@ -1,11 +1,11 @@ | |||
| FROM registry.svc.ci.openshift.org/ocp/builder:golang-1.14 AS builder | |||
| FROM registry.svc.ci.openshift.org/ocp/builder:rhel-8-golang-openshift-4.6 AS builder | |||
There was a problem hiding this comment.
Hmm, should this be Dockerfile.rhel8 or just Dockerfile.rhel now?
There was a problem hiding this comment.
https://github.com/openshift/ocp-build-data/blob/openshift-4.6-rhel-8/images/cluster-version-operator.yml#L7 is the Dockerfile in use via ocp-build-data
There was a problem hiding this comment.
I've filed #444 hung on this same bug using a symlink from a generic Dockerfile.rhel. If/when that lands, we can pivot ocp-build-data. And once all consumers have pivoted to the new name, we can drop the old name.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm cancel |
openshift-ci-robot
removed
lgtm
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-bot, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@openshift-bot: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1872080 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
So we don't have a nominally-rhel7 Dockerfile building RHEL 8 images and also so we don't need to manually bump this filename when we bump RHEL versions. We've had a RHEL 8 base since a4044f4 (Updating Dockerfile.rhel7 baseimages to mach ocp-build-data config, 2020-08-24, openshift#442). Once consumers have updated, we can remove the backwards-compat symlink.
This PR is autogenerated by the ocp-build-data-enforcer.
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the ocp-build-data repository used
for producing release artifacts.
If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.