Revert upgrade #226
Closed
Revert upgrade #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@JAORMX: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rhmdnd
added a commit
to rhmdnd/compliance-operator
that referenced
this pull request
Feb 21, 2023
Make it easier for contributors to find e2e tests available to run with `make e2e`. This also exposes an issue with test discovery. See issue openshift#226 for more details.
rhmdnd
added a commit
to rhmdnd/compliance-operator
that referenced
this pull request
Feb 21, 2023
Golang supports filtering tests using a -run flag, which can be a regular expressin. The e2e tests don't honor this flag since we're building the tests in a particular way so we can run parallel tests (e.g., non-destructive) tests before running the serial tests, which test remediations and other actions that affect the state of the cluster. It would be nice to run single tests so that you don't have to wait for the entire e2e test to run when developing new tests. This commit adds a framework flag that pulls the -run flag from the commandline invocation and attempts to filter e2e tests using the flag as if it were a regular expression. The idea was to re-use an existing flag that contributors are already familiar with instead of implementing a new flag for the same functionality that's specific to CO e2e tests. Fixes openshift#226
rhmdnd
added a commit
to rhmdnd/compliance-operator
that referenced
this pull request
Feb 21, 2023
Golang supports filtering tests using a -run flag, which can be a regular expression. The e2e tests don't honor this flag since we're building the tests in a particular way so we can run parallel tests (e.g., non-destructive) tests before running the serial tests, which test remediations and other actions that affect the state of the cluster. It would be nice to run single tests so that you don't have to wait for the entire e2e test to run when developing new tests. This commit adds a framework flag that pulls the -run flag from the command line invocation and attempts to filter e2e tests using the flag as if it were a regular expression. The idea was to re-use an existing flag that contributors are already familiar with instead of implementing a new flag for the same functionality that's specific to CO e2e tests. Fixes openshift#226
rhmdnd
added a commit
to rhmdnd/compliance-operator
that referenced
this pull request
Feb 22, 2023
Golang supports filtering tests using a -run flag, which can be a regular expression. The e2e tests don't honor this flag since we're building the tests in a particular way so we can run parallel tests (e.g., non-destructive) tests before running the serial tests, which test remediations and other actions that affect the state of the cluster, potentially affecting other tests. To make things more egonomic for contributors, it would be nice to run a single test so you don't have to wait for the entire suite to execute. This commit adds a framework flag that introduces a new command line argument called `-testRegex` and filters e2e tests using the flag as if it were a regular expression. Fixes openshift#226
rhmdnd
added a commit
to rhmdnd/compliance-operator
that referenced
this pull request
Feb 23, 2023
Golang supports filtering tests using a -run flag, which can be a regular expression. The e2e tests don't honor this flag since we're building the tests in a particular way so we can run parallel tests (e.g., non-destructive) tests before running the serial tests, which test remediations and other actions that affect the state of the cluster, potentially affecting other tests. To make things more egonomic for contributors, it would be nice to run a single test so you don't have to wait for the entire suite to execute. This commit adds a framework flag that introduces a new command line argument called `-testRegex` and filters e2e tests using the flag as if it were a regular expression. Fixes openshift#226
rhmdnd
added a commit
to rhmdnd/compliance-operator
that referenced
this pull request
Feb 28, 2023
The Makefile referenced an old example of how to run a single test that was inaccurate and outdated. Let's update it so that it's easier to understand how to invoke a single e2e test. Fixes openshift#226
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.