Bug 2025295: Add new option for VIRTIOWIN ConfigMap name #10616
Conversation
In OpenShift Virtualization 4.10.0, the VM-Import operator has been removed from the package, along with the config map. However, virtio-win image pullspec, which was included in that config map, is still required by the UI and has nothing to do with V2V. We are re-introducing this ConfigMap, but with more accurate name - . This PR adds one more option for that config map name, to support a smooth upgrade path, so it will work both with OCP 4.10 + CNV 4.9 and OCP 4.10 + CNV 4.10. Signed-off-by: orenc1 <ocohen@redhat.com>
orenc1
changed the title
openshift-ci
bot
added
bugzilla/severity-high
|
@orenc1: This pull request references Bugzilla bug 2025295, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: orenc1 <ocohen@redhat.com>
|
/test kubevirt-plugin |
|
Hi @yaacov , |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orenc1, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
|
@orenc1: This pull request references Bugzilla bug 2025295, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gouyang hi, we have a test that use We can't yet fix the tests because our install still installs the old config map, once we update the CNV version we will need to update the test too |
|
/bugzilla refresh |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
@yaacov: This pull request references Bugzilla bug 2025295, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
bugzilla/invalid-bug
|
/retest |
|
@orenc1: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2025295 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@orenc1: Bugzilla bug 2025295 is in an unrecognized state (CLOSED (ERRATA)) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In OpenShift Virtualization 4.10.0, the VM-Import operator has been removed from the package, along with the config map.
However, virtio-win image pullspec, which was included in that config map, is still required by the UI and has nothing to do with V2V.
We are re-introducing this ConfigMap, but with more accurate name -
virtio-winThis PR adds one more option for that config map name, to support a smooth upgrade path, so it will work both with OCP 4.10 + CNV 4.9 and OCP 4.10 + CNV 4.10.
This PR is a complementary for kubevirt/hyperconverged-cluster-operator#1647 made HCO.
Signed-off-by: orenc1 ocohen@redhat.com