-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1781101: fix(dev-catalog): reject the internal objects when creating from CSV #3518
Bug 1781101: fix(dev-catalog): reject the internal objects when creating from CSV #3518
Conversation
@abhinandan13jan is this ready for review now? |
040964e
to
fbf573c
Compare
fbf573c
to
6f2010f
Compare
/test analyze |
/test analyze |
@christianvogt yes |
Not able to verify the changes locally, looks like we are waiting for backend changes to be made. |
/lgtm cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Runtime error. Annotation is being treated as a JS array, but is a string.
frontend/packages/operator-lifecycle-manager/src/dev-catalog.ts
Outdated
Show resolved
Hide resolved
frontend/packages/operator-lifecycle-manager/src/dev-catalog.ts
Outdated
Show resolved
Hide resolved
frontend/packages/operator-lifecycle-manager/src/dev-catalog.ts
Outdated
Show resolved
Hide resolved
6f2010f
to
0dcaf8a
Compare
frontend/packages/operator-lifecycle-manager/src/dev-catalog.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Jon Jackson <jonjacks@redhat.com>
@TheRealJon Committed the latest suggestion 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, christianvogt, karthikjeeyar, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retitle Bug 1781101: fix(dev-catalog): reject the internal objects when creating from CSV |
@abhinandan13jan: All pull requests linked via external trackers have merged. Bugzilla bug 1781101 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.3 |
@christianvogt: new pull request created: #3729 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Addresses https://jira.coreos.com/browse/ODC-2263
P.S: try-catch is used as an annotation is a free string and can have any structure
Test cases:
Test 1: CSV with annotation and internal CRD present in array
![Screenshot from 2019-12-03 19-00-47](https://user-images.githubusercontent.com/24852534/70056409-6d22d880-1601-11ea-9486-7ed774f45ccf.png)
![Screenshot from 2019-12-03 19-00-06](https://user-images.githubusercontent.com/24852534/70056429-7318b980-1601-11ea-85de-3b884ed124cb.png)
Test 2: CSV with annotation and internal CRD not listed in array
![Screenshot from 2019-12-03 19-01-45](https://user-images.githubusercontent.com/24852534/70056486-8cba0100-1601-11ea-9184-8838a846142d.png)
![Screenshot from 2019-12-03 19-02-04](https://user-images.githubusercontent.com/24852534/70056489-8d529780-1601-11ea-94ef-8fe5b987ccd2.png)
Test 3: CSV with annotation and only internal CRD
![Screenshot from 2019-12-03 19-03-40](https://user-images.githubusercontent.com/24852534/70056560-ab1ffc80-1601-11ea-8fb3-198cf5bee0cd.png)
![Screenshot from 2019-12-03 19-04-03](https://user-images.githubusercontent.com/24852534/70056561-ab1ffc80-1601-11ea-82b4-2778e5a9112b.png)
Test 4: CSV without the required annotation at all
![Screenshot from 2019-12-03 19-05-22](https://user-images.githubusercontent.com/24852534/70056626-cbe85200-1601-11ea-8d9e-ace33e9824bd.png)
![Screenshot from 2019-12-03 19-05-40](https://user-images.githubusercontent.com/24852534/70056628-cbe85200-1601-11ea-922b-31dd5bc581c5.png)