Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downstream install uses yarn deps from sources #527

Conversation

sosiouxme
Copy link
Member

master edition of the same conversion from the 3.11 branch, just using latest master yarn.lock.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2018
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2018
@sosiouxme
Copy link
Member Author

/retest

@spadgett
Copy link
Member

OLM tests are broken. We're investigating...

@@ -0,0 +1,2 @@
401aa1438604b8e32306fa2bd4f8e211 node-v8.9.4-headers.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious what this file is for, its a tad cryptic.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah; it's for identifying sources downstream in dist-git; and unfortunately the mechanism breaks if I put any comments in the file 🙄

Arguably this doesn't belong in this upstream repo. But try as we might, the line between where ownership belongs on translating upstream into production builds remains fuzzy, mostly erring on the side of leaving control to the image owner. In this particular case this will likely be revised as we try to automate the process of updating bundled sources.

@sosiouxme
Copy link
Member Author

OLM itself was broken; possibly fixed with operator-framework/operator-lifecycle-manager#455 ?

@spadgett
Copy link
Member

jenkins rebuild

@spadgett
Copy link
Member

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 1aef412 into openshift:master Sep 13, 2018
@sosiouxme sosiouxme deleted the 20180912-next-downstream-sources branch September 14, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants