-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
downstream install uses yarn deps from sources #527
downstream install uses yarn deps from sources #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
OLM tests are broken. We're investigating... |
@@ -0,0 +1,2 @@ | |||
401aa1438604b8e32306fa2bd4f8e211 node-v8.9.4-headers.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious what this file is for, its a tad cryptic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah; it's for identifying sources downstream in dist-git; and unfortunately the mechanism breaks if I put any comments in the file 🙄
Arguably this doesn't belong in this upstream repo. But try as we might, the line between where ownership belongs on translating upstream into production builds remains fuzzy, mostly erring on the side of leaving control to the image owner. In this particular case this will likely be revised as we try to automate the process of updating bundled sources.
OLM itself was broken; possibly fixed with operator-framework/operator-lifecycle-manager#455 ? |
jenkins rebuild |
/refresh |
master edition of the same conversion from the 3.11 branch, just using latest master yarn.lock.