Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2097282: Rebase to v3.2.0 for OCP 4.11 #51

Merged
merged 69 commits into from
Jun 16, 2022

Conversation

jsafrane
Copy link

Diff to upstream v3.2.0:
kubernetes-csi/external-provisioner@v3.2.0...jsafrane:rebase-v3.2.0

@openshift/storage

SunnyFenng and others added 30 commits December 26, 2021 17:30
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>

Review feedback

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
feat: add an option to enable pprof profiling
kubernetes-csi/csi-release-tools@31aa44d1d Merge kubernetes-csi/csi-release-tools#182 from chrishenzie/csi-sanity-version
kubernetes-csi/csi-release-tools@f49e141ce Update csi-sanity test suite to v4.3.0
kubernetes-csi/csi-release-tools@d9815c284 Merge kubernetes-csi/csi-release-tools#181 from mauriciopoppe/armv7-support
kubernetes-csi/csi-release-tools@05c18012f Add support to build arm/v7 images
kubernetes-csi/csi-release-tools@4aedf357c Merge kubernetes-csi/csi-release-tools#178 from xing-yang/timeout
kubernetes-csi/csi-release-tools@2b9897eb6 Increase build timeout
kubernetes-csi/csi-release-tools@51d370295 Merge kubernetes-csi/csi-release-tools#177 from mauriciopoppe/kind-image-1.23
kubernetes-csi/csi-release-tools@a30efeac8 Add kind image for 1.23

git-subtree-dir: release-tools
git-subtree-split: 31aa44d1deef0a5055e40dad9ac7f6e8d410b7ef
…striction

relax same storageclass restriction
maximumVolumeSize should be updated when it changes
kubernetes-csi/csi-release-tools@335339f05 Merge kubernetes-csi/csi-release-tools#187 from mauriciopoppe/remove-eol-windows-versions
kubernetes-csi/csi-release-tools@890b87a28 Merge kubernetes-csi/csi-release-tools#188 from pwschuurman/update-release-notes-docs
kubernetes-csi/csi-release-tools@274bc9ba4 Update Sidecar Release Process documentation to reference latest syntax for release-notes tool
kubernetes-csi/csi-release-tools@87b6c3724 Merge kubernetes-csi/csi-release-tools#185 from Garima-Negi/fix-OWNERS-files
kubernetes-csi/csi-release-tools@f1de2c66b Fix OWNERS file - squashed commits
kubernetes-csi/csi-release-tools@59ae38b7b Remove EOL windows versions from BUILD_PLATFORMS
kubernetes-csi/csi-release-tools@5d664712a Merge kubernetes-csi/csi-release-tools#186 from humblec/sp
kubernetes-csi/csi-release-tools@d066f1ba6 Correct prow.sh typo and make codespell linter pass
kubernetes-csi/csi-release-tools@762e22d09 Merge kubernetes-csi/csi-release-tools#184 from pohly/image-publishing-troubleshooting
kubernetes-csi/csi-release-tools@81e26c3f8 SIDECAR_RELEASE_PROCESS.md: add troubleshooting for image publishing

git-subtree-dir: release-tools
git-subtree-split: 335339f059da0b8b1947794a8c75d9e5b973cb79
When external-provisioner runs in central mode, it needs to collect topology
labels from CSINode and Node to determine which topology segments exist in the
cluster. This benchmark measures how well the code for that works for different
combinations of cluster size and number of segments (determined by the number
of nodes per segment). It measures that for the initial segment creation and
for a refresh where nothing changes.

benchstat shows that the numbers are stable (± 3%). The following script can be
used to turn the output of benchstat into a csv that can be imported into
Google Docs when using the configuration that iterates over node sizes from 0
to 10000 in steps of 100:

for t in initial refresh; do echo $t; echo -e "nodes\tsegment size 1\tsegment size 10\tsegment size 100\tsegment size 1000\tsegment size 10000"; for n in $(seq 0 100 10000) ; do echo -n "$n"; for s in 1 10 100 1000 10000; do echo -n -e "\t$(grep numNodes=$n/segmentSize=$s/$t benchstat.out | sed -e 's/[^ ]* *\([^ ]*\) .*/\1/' -e 's/µs//' -e 's/ms/*1000/' | bc -l | tr . , )"; done; echo; done; echo; done >/tmp/data.csv
The rationale behind this change is that it allows external-provisioner to deal
with volumes without being slowed down by the concurrent CSIStorageCapacity
updates. Those updates are less important and the scheduler can deal with
outdated information, so enforcing a lower rate by default is acceptable.

If few changes are needed, updating CSIStorageCapacity keeps up with volume
changes. If many volumes get created or deleted quickly, throttling the
updating is beneficial because multiple changes can be combined into a single
update.

This has helped in practice during a scale test with 100 nodes and 10000
pods+volumes. Without this change, there were intermittent problems with an
unresponsive apiserver. With this change, no such problems occurred.
capacity: use separate client and lower QPS/Burst settings
capacity tracking: add benchmark for topology discovery
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Short declaration, variable declaration allignment and few other cleanups
…ter_client

Update external-snapshotter client to v6
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Added a hashing function that only hashes the passed in base and
prefix if the combined size is > the maxLength passed into the function
In this case the maximum length of a label.

Signed-off-by: Alexander Wels <awels@redhat.com>
controller: add pv secret annotation support to forget SC
k8s-ci-robot and others added 14 commits June 3, 2022 07:56
kubernetes-csi/csi-release-tools@e4dab7ff5 Merge kubernetes-csi/csi-release-tools#194 from yselkowitz/registry-k8s-io
kubernetes-csi/csi-release-tools@84a4d5a1d Move from k8s.gcr.io to registry.k8s.io

git-subtree-dir: release-tools
git-subtree-split: e4dab7ff57c24cf3e8d37cd3365636fddaff7e0a
use registry.k8s.io instead of k8s.gcr.io registry.
Signed-off-by: Gengtao Xu <gengtaox@amazon.com>
The DeleteFunc callback may get called with a cache.DeletedFinalStateUnknown
object. This needs to be handled as in
https://github.com/kubernetes-csi/external-attacher/blob/v3.2.1/pkg/controller/controller.go#L171-L173
controller: handle cache.DeletedFinalStateUnknown
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
make use of latest provisioner controller in storage-capacity.yaml
@openshift-ci openshift-ci bot requested review from bertinatto and gnufied June 15, 2022 12:29
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2022

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented Jun 15, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@jsafrane
Copy link
Author

/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2022

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane jsafrane changed the title 2097282: Rebase to v3.2.0 for OCP 4.11 Bug 2097282: Rebase to v3.2.0 for OCP 4.11 Jun 16, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2022

@jsafrane: This pull request references Bugzilla bug 2097282, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

Bug 2097282: Rebase to v3.2.0 for OCP 4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 0c7c708 into openshift:master Jun 16, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2022

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 2097282 has been moved to the MODIFIED state.

In response to this:

Bug 2097282: Rebase to v3.2.0 for OCP 4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.