Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2101343: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace #52

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

jsafrane
Copy link

Cherry-pick of kubernetes-csi#753 to 4.12.

The CSIStorageCapacity v1 check was attampting to create an invalid
object in the default namespace. This would fail if the pod did not
have permissions to the namespace. This will now use the namespace
specified in the NAMESPACE env variable.

cc @openshift/storage

The CSIStorageCapacity v1 check was attampting to create an invalid
object in the default namespace. This would fail if the pod did not
have permissions to the namespace. This will now use the namespace
specified in the NAMESPACE env variable.

Signed-off-by: N Balachandran <nibalach@redhat.com>
@openshift-ci openshift-ci bot requested review from bertinatto and tsmetana June 27, 2022 18:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
Copy link
Member

@tsmetana tsmetana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tsmetana
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jsafrane
Copy link
Author

/retest
kubelet is 1.23...

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 0c7c708 and 8 for PR HEAD ac9151c in total

@jsafrane jsafrane changed the title Bug: 2101343: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace Bug 2101343: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace Jun 28, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 28, 2022

@jsafrane: This pull request references Bugzilla bug 2101343, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

In response to this:

Bug 2101343: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 0c7c708 and 7 for PR HEAD ac9151c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0c7c708 and 6 for PR HEAD ac9151c in total

@jsafrane
Copy link
Author

/retest

1 similar comment
@jsafrane
Copy link
Author

/retest

@jsafrane
Copy link
Author

jsafrane commented Jun 30, 2022

it seems we won't get 1.24 kubelet soon and I want to fix it in 4.11 ASAP
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-gcp-csi

@jsafrane
Copy link
Author

/override ci/prow/e2e-aws-csi

@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-aws-csi, ci/prow/e2e-gcp-csi

In response to this:

it seems we won't get 1.24 kubelet soon and I want to fix it in 1.23
/override ci/prow/e2e-aws-csi
/override ci/prow/e2e-gcp-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Author

/cherry-pick release-4.11

@openshift-cherrypick-robot

@jsafrane: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-aws-csi

In response to this:

/override ci/prow/e2e-aws-csi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 02cab7d into openshift:master Jun 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2022

@jsafrane: All pull requests linked via external trackers have merged:

Bugzilla bug 2101343 has been moved to the MODIFIED state.

In response to this:

Bug 2101343: UPSTREAM: 2101343: fix: changed the csistoragecapacity check namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jsafrane: new pull request created: #53

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants