Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Start using rhel-coreos image rather than machine-os-content (#135)" #136

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Nov 14, 2023

This reverts commit 86bbea7.

We need to revert the openshift/os side of this because of remaining references to machine-os-content:

openshift/os#1393

So we have to revert this too.

…nt` (openshift#135)"

This reverts commit 86bbea7.

We need to revert the openshift/os side of this because of remaining
references to machine-os-content:

openshift/os#1393

So we have to revert this too.
@jlebon
Copy link
Member Author

jlebon commented Nov 15, 2023

/hold

openshift/os#1393 (comment)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@jlebon
Copy link
Member Author

jlebon commented Nov 15, 2023

/hold cancel

We're going to temporarily revert while we work on removing the final references in o/k.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2023
@soltysh soltysh added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. labels Nov 15, 2023
@soltysh
Copy link

soltysh commented Nov 15, 2023

Manually adding labels to get o/k unstuck.

@soltysh soltysh added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
Copy link

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jlebon, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlebon
Copy link
Member Author

jlebon commented Nov 15, 2023

error: failed to push image registry.build05.ci.openshift.org/ci-op-7tsnxii3/release:latest: unable to upload new layer (0): Patch "https://registry.build05.ci.openshift.org/v2/ci-op-7tsnxii3/release/blobs/uploads/c9a4737c-ce38-42ca-ae83-f026fe16929d?_state=eHIBtFWGRDME3EDt0mRE6H9a_qgJtYDpUeCoVNL8mL97Ik5hbWUiOiJjaS1vcC03dHNueGlpMy9yZWxlYXNlIiwiVVVJRCI6ImM5YTQ3MzdjLWNlMzgtNDJjYS1hZTgzLWYwMjZmZTE2OTI5ZCIsIk9mZnNldCI6MCwiU3RhcnRlZEF0IjoiMjAyMy0xMS0xNFQyMTo1Mjo0NS44MTQ5NDgwMzRaIn0%3D": operator "driver-toolkit" contained an invalid image-references file: no input image tag named "machine-os-content"

This is hitting the same issue (but in reverse) as when it initially went in. The last time, @ybettan ended up having to override the test failures (see #135 (comment) and following).

@soltysh
Copy link

soltysh commented Nov 15, 2023

This is hitting the same issue (but in reverse) as when it initially went in. The last time, @ybettan ended up having to override the test failures (see #135 (comment) and following).

can we get that then here as well?

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 86bbea7 and 2 for PR HEAD 13d90b4 in total

@ybettan
Copy link
Member

ybettan commented Nov 15, 2023

/override ci/prow/images
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-driver-toolkit-presubmit
/override ci/prow/e2e-upgrade

Copy link

openshift-ci bot commented Nov 15, 2023

@ybettan: Overrode contexts on behalf of ybettan: ci/prow/e2e-aws, ci/prow/e2e-aws-driver-toolkit-presubmit, ci/prow/e2e-upgrade, ci/prow/images

In response to this:

/override ci/prow/images
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-driver-toolkit-presubmit
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f259897 into openshift:master Nov 15, 2023
Copy link

openshift-ci bot commented Nov 15, 2023

@ybettan: Overrode contexts on behalf of ybettan: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Nov 15, 2023

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build driver-toolkit-container-v4.15.0-202311151750.p0.gf259897.assembly.stream for distgit driver-toolkit.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants