Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update enhancement template #1555

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

dhellmann
Copy link
Contributor

  • be more explicit about looking for details for our different product topologies
  • update the outline levels for some sections
  • misc smaller wording changes

guidelines/enhancement_template.md Outdated Show resolved Hide resolved
guidelines/enhancement_template.md Show resolved Hide resolved
Co-authored-by: Aravindh Puthiyaparambil <aravindhp@users.noreply.github.com>
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

openshift-ci bot commented Feb 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

copejon added a commit to copejon/enhancements that referenced this pull request Feb 14, 2024
copejon added a commit to copejon/enhancements that referenced this pull request Feb 14, 2024
copejon added a commit to copejon/enhancements that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants