Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

observability: Add multicluster-observability-addon proposal #1613

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

observability: Add multicluster-observability-addon proposal #1613

wants to merge 8 commits into from

Conversation

JoaoBraveCoding
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@JoaoBraveCoding JoaoBraveCoding force-pushed the multicluster-observability-addon branch 2 times, most recently from f405a5b to c3299fa Compare April 26, 2024 17:19
@JoaoBraveCoding JoaoBraveCoding marked this pull request as ready for review April 26, 2024 17:21
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 26, 2024
@openshift-ci openshift-ci bot requested review from jan--f and jotak April 26, 2024 17:21
@JoaoBraveCoding JoaoBraveCoding force-pushed the multicluster-observability-addon branch from c3299fa to fee3691 Compare April 26, 2024 18:01
@periklis periklis mentioned this pull request Apr 29, 2024
Closed
periklis
periklis reviewed Apr 29, 2024
View reviewed changes
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
hack/install-markdownlint.sh Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
iblancasa
iblancasa reviewed May 3, 2024
View reviewed changes
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
@iblancasa iblancasa mentioned this pull request May 20, 2024
Merged
5 tasks
periklis
periklis reviewed Jun 13, 2024
View reviewed changes
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
enhancements/observability/multicluster-observability-addon.md Outdated Show resolved Hide resolved
@periklis
Copy link
Contributor

/approve

JoaoBraveCoding and others added 7 commits June 27, 2024 12:22
@JoaoBraveCoding
observability: Add multicluster-observability-addon proposal
31b5e4f
@JoaoBraveCoding @periklis
Apply suggestions from code review
ce70800 
Co-authored-by: Periklis Tsirakidis <periklis@nefeli.eu>
@JoaoBraveCoding
address review comments
bf98179
@JoaoBraveCoding @jan--f @iblancasa
Apply suggestions from code review
5ef2409 
Co-authored-by: Jan Fajerski <jan--f@users.noreply.github.com>
Co-authored-by: Israel Blancas <iblancasa@gmail.com>
@JoaoBraveCoding
Update proposal to brig it up to speed with the latest developments
d9a0582
@JoaoBraveCoding @periklis
Apply suggestions from code review
3fcc0bc 
Co-authored-by: Periklis Tsirakidis <periklis@nefeli.eu>
@JoaoBraveCoding
address review
ad82ef4
@JoaoBraveCoding JoaoBraveCoding force-pushed the multicluster-observability-addon branch from 11f4ca8 to 1ddc36b Compare June 27, 2024 11:27
JoaoBraveCoding
JoaoBraveCoding commented Jun 27, 2024
View reviewed changes
enhancements/observability/multicluster-observability-addon.md
- cluster-logs
```

#### Multi Cluster OTLP Collection and Forwarding
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iblancasa could you please add a commit to this PR updating the resources for the tracing side? I'm mainly concerned with an up-to-date example of the OpenTelemetryCollector and the resulting resource in the ManifestWorks

@JoaoBraveCoding JoaoBraveCoding force-pushed the multicluster-observability-addon branch from 1ddc36b to d6c6627 Compare June 27, 2024 11:34
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 27, 2024

@JoaoBraveCoding: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/markdownlint d6c6627 link true /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2024
@periklis
Copy link
Contributor

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis left review comments

@jan--f jan--f jan--f left review comments

@iblancasa iblancasa iblancasa left review comments

@pavolloffay pavolloffay pavolloffay left review comments

@jgomezselles jgomezselles jgomezselles left review comments

@jotak jotak Awaiting requested review from jotak

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JoaoBraveCoding @periklis @openshift-bot @jan--f @iblancasa @pavolloffay @jgomezselles