Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: OpenShift Virtualization Higher Density #1630

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat: OpenShift Virtualization Higher Density #1630

wants to merge 14 commits into from

Conversation

fabiand
Copy link

@fabiand fabiand commented May 27, 2024

A feature describing CNV's path to higher density based on

  • phase 1: wasp
  • phase 2: kube swap

@fabiand
Copy link
Author

fabiand commented May 27, 2024

cc @enp0s3 @iholder101

@openshift-ci openshift-ci bot requested review from cybertron and runcom May 27, 2024 13:02
enp0s3
enp0s3 reviewed Jun 1, 2024
View reviewed changes
Copy link

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiand Thank you!

enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
iholder101
iholder101 reviewed Jun 2, 2024
View reviewed changes
Copy link

@iholder101 iholder101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fabiand!

enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
@fabiand
Copy link
Author

fabiand commented Jun 3, 2024

@enp0s3 @iholder101 many thanks for your inputs! I've addressed them and resolved consversations.
Please reopen conversations if you disagree.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tkashem for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fabiand
Copy link
Author

fabiand commented Jun 12, 2024

@fabiand: all tests passed!

Thank you so much.

enp0s3
enp0s3 reviewed Jun 13, 2024
View reviewed changes
Copy link

@enp0s3 enp0s3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiand Hi, did second round, have some few cooments/ideas

enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Show resolved Hide resolved
enhancements/kubelet/virtualization-higher-workload-density.md Outdated Show resolved Hide resolved
@fabiand
feat: OpenShift Virtualization Higher Density
87ce6f4 
A feature describing CNV's path to higher density based on

- phase 1: wasp
- phase 2: kube swap

Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: Swap add more design details
64eb060 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: Drop all xml style comments to make the md linter happy
16bbc80 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: Address Igor's comments
f0af1f7 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: Address Itamar's comments
474c5d7 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: Add line breaks
13610ce 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: fix headers
7bdd858 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: Fix table header
e59182d 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: Mention KSM and FPR
68a8501 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv: Add section to make linter happy
68617c6 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv,swap Fix metadata
4de46f8 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv,swap: Clarification of VM vs infra overhead
0add279 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv,swap: Address more review comments
882a814 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
cnv,swap: Addressed more comments
f87092a 
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
@fabiand
Copy link
Author

fabiand commented Jun 26, 2024

All set.

@fabiand fabiand mentioned this pull request Jun 26, 2024
Closed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

@fabiand: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@iholder101
Copy link

Looks great to me!
/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

@iholder101: changing LGTM is restricted to collaborators

In response to this:

Looks great to me!
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2024
@enp0s3
Copy link

enp0s3 commented Jul 30, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 30, 2024
@enp0s3
Copy link

enp0s3 commented Jul 30, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024
@fabiand
Copy link
Author

fabiand commented Aug 13, 2024

@mrunalp can we get this merged or reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enp0s3 enp0s3 enp0s3 left review comments

@iholder101 iholder101 iholder101 left review comments

@Barakmor1 Barakmor1 Barakmor1 left review comments

@cybertron cybertron Awaiting requested review from cybertron

@runcom runcom Awaiting requested review from runcom

Assignees

@enp0s3 enp0s3

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fabiand @iholder101 @openshift-bot @enp0s3 @Barakmor1