Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-706: Optionally disable LVMS and CSI deployment #1653

Merged
merged 8 commits into from
Jul 24, 2024
Merged

USHIFT-706: Optionally disable LVMS and CSI deployment #1653

merged 8 commits into from
Jul 24, 2024

Conversation

copejon
Copy link
Contributor

@copejon copejon commented Jul 11, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2024 •
edited by openshift-ci bot

@copejon: This pull request references USHIFT-706 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jakobmoellerdev
jakobmoellerdev reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats a great EP imo, I think this is much more feasible and supportable than the separate rpms

enhancements/microshift/disabling-storage-components.md Outdated Show resolved Hide resolved
enhancements/microshift/disabling-storage-components.md Show resolved Hide resolved
enhancements/microshift/disabling-storage-components.md Show resolved Hide resolved
@copejon
init
ce40073
@copejon
linter fixes
d4b0366
@copejon
added config step to uninstall
86b54f3 
hopefully clarified the csi field under api extensions
@copejon
fixed truncated sentence
40cc364 
clarified user uninstall actions
@copejon
optional step for workloads that can be run without persistent storage
6d59db8 
clarified user story to call out persistent storage is applicable to cluster workloads only
@copejon
corrected old metrics data point
75b067f
jakobmoellerdev
jakobmoellerdev reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jakobmoellerdev jakobmoellerdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice proposal!

pmtk
pmtk reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@pmtk pmtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment about wrong word (almost a typo). LGTM

enhancements/microshift/disabling-storage-components.md Outdated Show resolved Hide resolved
enhancements/microshift/disabling-storage-components.md Show resolved Hide resolved
@copejon @pmtk
Update enhancements/microshift/disabling-storage-components.md
39a3801 
Co-authored-by: Patryk Matuszak <pmtk@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jerpeter1 jerpeter1 self-assigned this Jul 24, 2024
@jerpeter1
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerpeter1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit fc4de7f into openshift:master Jul 24, 2024
2 checks passed
@copejon copejon deleted the ushift-706 branch July 24, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmtk pmtk pmtk left review comments

@pacevedom pacevedom pacevedom left review comments

@jakobmoellerdev jakobmoellerdev jakobmoellerdev left review comments

@jerpeter1 jerpeter1 jerpeter1 left review comments

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@jcantrill jcantrill Awaiting requested review from jcantrill

Assignees

@jerpeter1 jerpeter1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@copejon @openshift-ci-robot @jerpeter1 @pmtk @pacevedom @jakobmoellerdev @ShaunaDiaz