Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1746965: openshift-4.3: rebase 3.3.11 #16

Closed
wants to merge 15 commits into from
Closed

Bug 1746965: openshift-4.3: rebase 3.3.11 #16

wants to merge 15 commits into from

Conversation

hexfusion
Copy link

@hexfusion hexfusion commented Aug 29, 2019 •
edited
Loading

The following PR is one of a series as we move from 3.3.10 to 3.3.15 to match etcd server to the client in the k8s 1.16 release.

gyuho and others added 15 commits October 10, 2018 13:30
@gyuho
version: 3.3.10+git
6f250f9 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
travis: use Go 1.10.7
3a7b8b3 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
grpcproxy: fix memory leak
59cc0f9 
use set instead of slice as interval value

fixes etcd-io#10326
@gyuho
Merge pull request etcd-io#10335 from gyuho/release-3.3-patch
e6b2f00 
[Cherry pick 3.3] grpcproxy: fix memory leak
@hexfusion
auth: disable CommonName auth for gRPC-gateway
c7f744d 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
auth: fix cherry-pick
1590373 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@gyuho
version: 3.3.11
2cf9e51 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@hexfusion
version: openshift-v4.0
8656f84 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Dockerfile: add etcdctl
a1875f2 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@wking @hexfusion
Dockerfile.*: Fix "etcd is distributed" -> "etcd is a distributed"
ca03461 
Correcting a typo from 2f10964 (version: openshift-v4.0, 2018-11-29).
@hexfusion
Dockerfile: resolve issue where binary was not properly copied from b…
f444a0d 
…uild.

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
*: Change gRPC proxy to expose etcd server endpoint /metrics
ab2fb13 
This PR resolves an issue where the `/metrics` endpoints exposed by the proxy were not returning metrics of the etcd members servers but of the proxy itself.

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Dockerfile: set coreos org as canonical for release-3.3
85c138b 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
OWNERS: add
2114dbe 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@hexfusion
Dockerfile: bump golang to 1.11
f0039e4 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2019
@hexfusion hexfusion changed the title openshift-4.3: rebase 3.3.11 WIP openshift-4.3: rebase 3.3.11 Aug 29, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2019
@hexfusion hexfusion changed the title WIP openshift-4.3: rebase 3.3.11 Bug 1746965 : openshift-4.3: rebase 3.3.11 Aug 29, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 29, 2019
@hexfusion
Copy link
Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@hexfusion
Copy link
Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@hexfusion: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion changed the title Bug 1746965 : openshift-4.3: rebase 3.3.11 Bug 1746965: openshift-4.3: rebase 3.3.11 Aug 29, 2019
@openshift-ci-robot
Copy link

@hexfusion: This pull request references Bugzilla bug 1746965, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1746965: openshift-4.3: rebase 3.3.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 29, 2019
@hexfusion
Copy link
Author

/retest

@openshift-ci-robot
Copy link

@hexfusion: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws f0039e4 link /test e2e-aws
ci/prow/images f0039e4 link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hexfusion
Copy link
Author

/close

Closing in favor of #20

@openshift-ci-robot
Copy link

@hexfusion: Closed this PR.

In response to this:

/close

Closing in favor of #20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hexfusion hexfusion deleted the rb-v3.3.11 branch April 7, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawford crawford Awaiting requested review from crawford

@deads2k deads2k Awaiting requested review from deads2k

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hexfusion @openshift-ci-robot @gyuho @wking