Bug 1958405: UPSTREAM: <carry>: *: log server-side /health checks

[hexfusion]

manual cherry-pick of etcd-io#11704 into openshift-4.8

Health check reporting Before

2021-05-11 20:55:27.862866 I | etcdserver/api/etcdhttp: /health OK (status code 200)

After

{"level":"info","ts":"2021-05-12T00:21:55.349Z","caller":"etcdhttp/metrics.go:127","msg":"serving /health true"}
{"level":"info","ts":"2021-05-12T00:21:55.350Z","caller":"etcdhttp/metrics.go:65","msg":"/health OK","status-code":200}

This is of course too verbose which is why we need #80

The end goal will be providing a machine consumable etcd log which is persisted to the host and then rotated in the same fashion that audit logs for kube-apiserver work today. By ensuring healtch checks are taken at a 1s granularity and failures reported we can ensure with great precision the availability or lack thereof with regards to etcd service availability.

[openshift-ci]

@hexfusion: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

UPSTREAM: : *: log server-side /health checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@hexfusion: This pull request references Bugzilla bug 1958405, which is invalid:

• expected Bugzilla bug 1958405 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1958405: UPSTREAM: : *: log server-side /health checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

/retest

[lilic]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, lilic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hexfusion]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[hexfusion]

/hold for perf review

[openshift-ci]

@hexfusion: This pull request references Bugzilla bug 1958405, which is invalid:

• expected Bugzilla bug 1958405 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1958405: UPSTREAM: : *: log server-side /health checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@hexfusion: This pull request references Bugzilla bug 1958405, which is invalid:

• expected Bugzilla bug 1958405 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1958405: UPSTREAM: : *: log server-side /health checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hexfusion]

cpu, and RSS are not affected I had a slight concern about creating logger config.

/hold cancel

[hexfusion]

we are a fork so invalid BZ is not accurate and GL approval is not required at this point so manually checking boxes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@hexfusion: This pull request references Bugzilla bug 1958405, which is invalid:

• expected Bugzilla bug 1958405 to depend on a bug targeting a release in 4.9.0 and in one of the following states: MODIFIED, VERIFIED, but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1958405: UPSTREAM: : *: log server-side /health checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@hexfusion: All pull requests linked via external trackers have merged:

• openshift/etcd#78

Bugzilla bug 1958405 has been moved to the MODIFIED state.

In response to this:

Bug 1958405: UPSTREAM: : *: log server-side /health checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.